fix: Telemetry blocks startup when offline #2794
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anty0
requested changes
Dec 21, 2024
| HttpMethod.POST, | ||
| Unit::class.java, | ||
| ) | ||
| } catch (e: Throwable) { |
There was a problem hiding this comment.
Suggested change
| } catch (e: Throwable) { | |
| } catch (e: Exception) { |
Catch exception only. Catching errors as well is probably a bad idea.
There was a problem hiding this comment.
Noob question... but... Why is it bad idea? 🤔
There was a problem hiding this comment.
It is usually discouraged because it is generally impossible to recover from such errors programmatically anyway, and ignoring them (by catching them) only makes the issue worse. See: https://stackoverflow.com/a/2274130.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.