-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make namespaces opt-in #2786
Merged
Merged
Make namespaces opt-in #2786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StaNov
force-pushed
the
stanov/#2594-namespaces-opt-in
branch
3 times, most recently
from
December 17, 2024 15:01
9e97d24
to
7c84bf5
Compare
stepan662
requested changes
Dec 17, 2024
webapp/src/views/projects/project/components/DefaultNamespaceSelect.tsx
Outdated
Show resolved
Hide resolved
.../test/kotlin/io/tolgee/api/v2/controllers/v2KeyController/KeyControllerWithNamespacesTest.kt
Show resolved
Hide resolved
...est/kotlin/io/tolgee/api/v2/controllers/v2ImportController/SingleStepImportControllerTest.kt
Show resolved
Hide resolved
StaNov
force-pushed
the
stanov/#2594-namespaces-opt-in
branch
from
December 18, 2024 10:06
bc71869
to
ea6aebb
Compare
JanCizmar
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
backend/data/src/main/kotlin/io/tolgee/service/dataImport/CoreImportFilesProcessor.kt
Outdated
Show resolved
Hide resolved
backend/data/src/main/kotlin/io/tolgee/service/dataImport/CoreImportFilesProcessor.kt
Outdated
Show resolved
Hide resolved
backend/data/src/main/kotlin/io/tolgee/service/dataImport/CoreImportFilesProcessor.kt
Outdated
Show resolved
Hide resolved
backend/data/src/main/kotlin/io/tolgee/service/project/ProjectService.kt
Outdated
Show resolved
Hide resolved
JanCizmar
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing!
StaNov
force-pushed
the
stanov/#2594-namespaces-opt-in
branch
6 times, most recently
from
December 18, 2024 14:46
709726e
to
c1e80e7
Compare
StaNov
force-pushed
the
stanov/#2594-namespaces-opt-in
branch
2 times, most recently
from
December 18, 2024 15:29
ea4dd4e
to
93ddc13
Compare
StaNov
force-pushed
the
stanov/#2594-namespaces-opt-in
branch
2 times, most recently
from
December 18, 2024 16:46
26aa485
to
f04e947
Compare
stepan662
force-pushed
the
stanov/#2594-namespaces-opt-in
branch
from
December 19, 2024 10:26
b23639d
to
3c0951d
Compare
stepan662
approved these changes
Dec 19, 2024
Merging despite of changes requested since we discussed them personally with @JanCizmar. |
StaNov
added a commit
that referenced
this pull request
Dec 20, 2024
Closes #2594. --------- Co-authored-by: StaNov <[email protected]> Co-authored-by: Štěpán Granát <[email protected]> (cherry picked from commit 4a8c938)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2594.