Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Compose multiplatform strings import & export #2649

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

Anty0
Copy link
Collaborator

@Anty0 Anty0 commented Oct 30, 2024

Fixes #2397

@Anty0 Anty0 changed the title Compose multiplatform strings import & export feat: Compose multiplatform strings import & export Oct 30, 2024
@Anty0 Anty0 force-pushed the jirikuchynka/compose-multiplatform branch from 6aa07de to 8812d76 Compare October 31, 2024 09:36
@Anty0 Anty0 force-pushed the jirikuchynka/compose-multiplatform branch 2 times, most recently from ce03860 to 8dac4ad Compare December 18, 2024 14:06
@Anty0 Anty0 force-pushed the jirikuchynka/compose-multiplatform branch from abe6d79 to b149de6 Compare December 19, 2024 15:18
@Anty0 Anty0 requested a review from JanCizmar December 19, 2024 16:17
Copy link
Contributor

@JanCizmar JanCizmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -59,8 +59,8 @@ class AndroidXmlFileExporterTest {
|<resources xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2">
| <string name="i_am_array_english">This is english!</string>
| <plurals name="plural_with_placeholders">
| <item quantity="one">%s dog</item>
| <item quantity="other">%s dogs</item>
| <item quantity="one">%1${'$'}s dog</item>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export strings for Compose Multiplatform
2 participants