-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Compose multiplatform strings import & export #2649
Draft
Anty0
wants to merge
15
commits into
main
Choose a base branch
from
jirikuchynka/compose-multiplatform
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anty0
changed the title
Compose multiplatform strings import & export
feat: Compose multiplatform strings import & export
Oct 30, 2024
Anty0
force-pushed
the
jirikuchynka/compose-multiplatform
branch
from
October 31, 2024 09:36
6aa07de
to
8812d76
Compare
Anty0
force-pushed
the
jirikuchynka/compose-multiplatform
branch
2 times, most recently
from
December 18, 2024 14:06
ce03860
to
8dac4ad
Compare
Anty0
force-pushed
the
jirikuchynka/compose-multiplatform
branch
from
December 19, 2024 15:18
abe6d79
to
b149de6
Compare
JanCizmar
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@@ -59,8 +59,8 @@ class AndroidXmlFileExporterTest { | |||
|<resources xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2"> | |||
| <string name="i_am_array_english">This is english!</string> | |||
| <plurals name="plural_with_placeholders"> | |||
| <item quantity="one">%s dog</item> | |||
| <item quantity="other">%s dogs</item> | |||
| <item quantity="one">%1${'$'}s dog</item> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2397