feat: sync & compare commands #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepan662
requested changes
Jan 11, 2023
There was a problem hiding this comment.
Good job with the speed improvements 👍
I was briefely testing it with the tolgee-platform and i've noticed following issues:
- fails when project has no keys yet
TypeError: Cannot read properties of undefined (reading 'keys')
at /Users/stepangranat/Projects/tolgee/tolgee-cli/dist/client/project.js:20:38
- node gives me this warning:
(node:92961) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [Worker]. Use emitter.setMaxListeners() to increase limit
at _addListener (node:events:601:17)
at Worker.addListener (node:events:619:10)
at Worker.once (node:events:663:8)
at callWorker (/Users/stepangranat/Projects/tolgee/tolgee-cli/dist/extractor/worker.js:50:12)
it was not actually leaking anything, but we were exceeding Node's maximum event listener count for the Worker object when real workloads were hitting it
|
When the extraction is running, there should be the cool animation of running mouse I've created before. This is important! ⬆️ |
*hissing cat noises*
stepan662
approved these changes
Jan 13, 2023
|
🎉 This PR is included in version 1.0.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The long awaited commands to sync code projects and localization projects!
tolgee compareis essentially a dry-run oftolgee sync. There is the option to skip deleting unused keys when syncing, aborting on warnings, and dumping a backup of all keys before syncing.