Skip to content
This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

Adds a DatePicker to EditView.xaml for the End Date. #4804

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

daiplusplus
Copy link

@daiplusplus daiplusplus commented Jan 23, 2021

📒 Description

This change adds a second <DatePicker> to EditView.xaml which displays the Date component of an event's end timestamp and integrates it with EditView's plumbing.

For my motivation, see https://github.com/toggl-open-source/toggldesktop/issues/2582

🕶️ Types of changes

New feature (non-breaking change which adds functionality)

🤯 List of changes

  • The EditView.xaml now has this layout and UI:
    image

  • EditView.xaml.cs is updated with changes to integrate the End DatePicker.

  • Also fixes build issues with the Windows project by specifying updated paths for the Windows 10 SDK's *.winmd files. Other users can add their own paths as well, if necessary, without breaking the <HintPath> for other users.

👫 Relationships

https://github.com/toggl-open-source/toggldesktop/issues/2582

Closes #2582

🔎 Review hints

I did some cursory testing for both Existing and New entries. I ran all tests in the solution - I wanted to add some UI integration tests for this change but I didn't see any, unfortunately. I did have unit test failures that were unrelated to my changes.

I'm perplexed by the design of Toggl's native API - I don't know why it treats the end-time as a localized time-only string instead of passing around only UNIX timestamp integers, that would make the Toggl API much simpler to work with and easier to understand.

@daiplusplus daiplusplus changed the title Adds a Adds a DatePicker for the End Date. Jan 23, 2021
@daiplusplus daiplusplus changed the title Adds a DatePicker for the End Date. Adds a DatePicker to EditView.xaml for the End Date. Jan 23, 2021
@daiplusplus
Copy link
Author

@atsvirchkova @skel35 I noticed other PRs ahead of mine have already been reviewed and merged - so I was wondering where in your review pipeline (or kanban board) this PR is currently at. Thanks!

@daiplusplus
Copy link
Author

@AndrewVebster @skel35 @atsvirchkova ping?

@rzfzr
Copy link

rzfzr commented Jul 20, 2021

@AndrewVebster @skel35 @atsvirchkova ping?

Is this project dead?
I created a few issues, one of them was a year ago, all of them if no response, I came back here thinking about getting my hands dirty, but if the PRs are not being merged I lose a bit of interest....
Is the company abandoning this project and switching to a PWA? I think we should be aware of anything like this....
Edit. bunch of typos

@skel35
Copy link
Contributor

skel35 commented Jul 21, 2021

Hi @Jehoel @rzfzr!
This project is in a partially frozen state. We're planning to have refreshed native apps in the future without our outdated C++ core which has piled a lot of tech debt by now. The new apps will also be closed-source at first, although this can change in the future.
This is still our main desktop app at the moment and we can publish new releases if we have the need to. But since this project is not in active development, we generally don't want to publish any cosmetic or small updates to it and we treat any issues/requests as requests for the new apps.

@daiplusplus
Copy link
Author

daiplusplus commented Jul 21, 2021

@skel35 no worries, I cancelled my subscription to Toggl out of disgust for your company's contempt, or at least diregard, for open-source contributors ages ago :)

@rzfzr
Copy link

rzfzr commented Jul 21, 2021

@skel35 thanks for the quick reply! Would you be so kind to put this "crucial bug fixing" disclaimer first thing in the main Readme? Just feels fair, every non accepted PR is a competent someone that likes this product so much that they took time out of their day, and waste it... that's the recipe for getting reactions like Jehoel's...

@skel35
Copy link
Contributor

skel35 commented Jul 21, 2021

@rzfzr You're right that this information should've been shared publicly earlier. Thank you for the feedback. I've added a disclaimer to the top of the repo's Readme.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Option to use separate full date+time pickers for Start and End time
3 participants