This repository has been archived by the owner on Feb 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 278
[WIP] Port the Linux app to QML and partially implement the macOS design #3618
Open
MartinBriza
wants to merge
86
commits into
master
Choose a base branch
from
feature/linux-qml
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBriza
force-pushed
the
feature/linux-qml
branch
12 times, most recently
from
July 14, 2020 13:10
41810e7
to
053b7cd
Compare
It probably doesn't work in this state though
Doesn't really work yet
MartinBriza
force-pushed
the
feature/linux-qml
branch
from
September 4, 2020 12:37
053b7cd
to
6b580ca
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📒 Description
This change is a partial implementation of our current macOS app design and an almost full port of the current Linux app to QML.
This gives us the ability to create pretty UI really fast and also animations and potentially better performance because of better handling of underlying data models.
Stuff is now in pretty rough state, below is a list of stuff that still needs work:
.. the list will get expanded over time, this is just stuff I can come up with from the top of my head.
🕶️ Types of changes
🤯 List of changes
🔎 Review hints
Test everything.
It's possible to run this branch on macOS. To be able to compile, you have to set the variables in the following
cmake
command (systemwide openssl doesn't have headers and tests just don't build because of some platform-dependent... uhhh, mess) and also pointcmake
to where to look for your Qt install:It's also possible to build it on Windows but I wasn't able to run it.