Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile testing infrastructure #9044

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alsuren
Copy link

@alsuren alsuren commented Dec 23, 2024

My eventual aim is to make kanban drag and drop work on mobile. I've still not managed that, but I thought I could contribute my testing infrastructure already.

To avoid burning github actions minutes and have a billion failing tests to sort out, I made it only run interesting tests on mobile. The rest of the tests are run on desktop.

  • .spec.ts files are run on desktop only
  • .mobile.spec.ts files are run on mobile only
  • .shared.spec.ts files are run on both desktop and mobile

If you remove the test.skip(), my mobile test does correctly fail. I may need to rewrite it to send touch events once I've implemented the feature, but I will think about that later.

@alsuren alsuren requested a review from a team as a code owner December 23, 2024 18:27
Copy link

changeset-bot bot commented Dec 23, 2024

⚠️ No Changeset found

Latest commit: b5e4030

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 6:28pm

Copy link

vercel bot commented Dec 23, 2024

@alsuren is attempting to deploy a commit to the toeverything Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

nx-cloud bot commented Dec 23, 2024

View your CI Pipeline Execution ↗ for commit b5e4030.

Command Status Duration Result
nx vite:build @blocksuite/playground ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-23 18:28:32 UTC

Copy link

graphite-app bot commented Dec 23, 2024

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant