Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(std): pan and pinch events were calculate relative to only one finger #8870

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

majula2111
Copy link
Contributor

@majula2111 majula2111 commented Dec 5, 2024

Improves the calculation of multi-touch gestures and makes them smoother on Android and fixes them on iOS
master android samsung galaxy s24 chrome:

2024-12-05.15.26.26.mp4

Visible jumps during pan gesture
current branch with fix android samsung galaxy s24 chrome:

2024-12-05.15.26.30.mp4

Smooth pan gesture with two fingers without jumping

@majula2111 majula2111 requested a review from a team as a code owner December 5, 2024 12:28
Copy link

changeset-bot bot commented Dec 5, 2024

⚠️ No Changeset found

Latest commit: 22e87c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 1:01pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 1:01pm

Copy link

vercel bot commented Dec 5, 2024

Someone is attempting to deploy a commit to the toeverything Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

graphite-app bot commented Dec 5, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

nx-cloud bot commented Dec 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 22e87c5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@doodlewind doodlewind enabled auto-merge (squash) December 6, 2024 07:23
@doodlewind doodlewind disabled auto-merge December 6, 2024 07:23
@doodlewind doodlewind merged commit dc44577 into toeverything:master Dec 6, 2024
35 checks passed
@github-actions github-actions bot mentioned this pull request Dec 6, 2024
OlegDev1 pushed a commit to OlegDev1/blocksuite that referenced this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants