Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: history webhook api #536

Merged
merged 8 commits into from
Sep 14, 2023
Merged

feat: history webhook api #536

merged 8 commits into from
Sep 14, 2023

Conversation

darkskygit
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octobase 🛑 Canceled (Inspect) Sep 14, 2023 6:19am

@darkskygit darkskygit temporarily deployed to development September 13, 2023 10:56 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development September 13, 2023 10:56 — with GitHub Actions Inactive
@github-actions
Copy link

Benchmark for Linux

Click to view benchmark
Test Base PR %

Benchmark for Windows

Click to view benchmark
Test Base PR %

@darkskygit darkskygit temporarily deployed to development September 13, 2023 14:22 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development September 13, 2023 14:22 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development September 13, 2023 15:07 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development September 13, 2023 15:07 — with GitHub Actions Inactive
@github-actions
Copy link

Benchmark for Linux

Click to view benchmark
Test Base PR %

Benchmark for Windows

Click to view benchmark
Test Base PR %

@darkskygit darkskygit temporarily deployed to development September 13, 2023 15:53 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development September 13, 2023 15:53 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 77.68% and project coverage change: +0.32% 🎉

Comparison is base (48f04de) 65.97% compared to head (f2c33bf) 66.30%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
+ Coverage   65.97%   66.30%   +0.32%     
==========================================
  Files         113      115       +2     
  Lines       12492    12570      +78     
==========================================
+ Hits         8242     8334      +92     
+ Misses       4250     4236      -14     
Files Changed Coverage Δ
apps/doc_merger/src/main.rs 0.00% <0.00%> (ø)
apps/keck/src/server/api/blocks/block.rs 38.40% <ø> (-0.90%) ⬇️
apps/keck/src/server/api/blocks/schema.rs 100.00% <ø> (ø)
apps/keck/src/server/api/blocks/workspace.rs 71.87% <ø> (-6.55%) ⬇️
apps/keck/src/server/api/doc.rs 93.10% <ø> (ø)
apps/keck/src/server/mod.rs 0.00% <0.00%> (ø)
...ibs/jwst-codec/src/doc/types/list/search_marker.rs 83.73% <ø> (ø)
libs/jwst-codec/src/lib.rs 100.00% <ø> (ø)
libs/jwst-rpc/src/broadcast.rs 0.00% <0.00%> (ø)
libs/jwst-rpc/src/connector/memory.rs 0.00% <0.00%> (ø)
... and 15 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

Benchmark for Linux

Click to view benchmark
Test Base PR %

Benchmark for Windows

Click to view benchmark
Test Base PR %

thorseraq
thorseraq previously approved these changes Sep 14, 2023
///
/// NOTE: The probability of 36% of the random number generated by
/// this function is greater than [u32::MAX]
fn prefer_small_random() -> u64 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

forehalo
forehalo previously approved these changes Sep 14, 2023
@darkskygit darkskygit temporarily deployed to development September 14, 2023 06:17 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development September 14, 2023 06:17 — with GitHub Actions Inactive
@github-actions
Copy link

Benchmark for Linux

Click to view benchmark
Test Base PR %

Benchmark for Windows

Click to view benchmark
Test Base PR %

@darkskygit darkskygit merged commit 06ca581 into master Sep 14, 2023
14 checks passed
@darkskygit darkskygit deleted the darksky/history_webhook branch September 14, 2023 07:09
darkskygit added a commit to y-crdt/y-octo that referenced this pull request Sep 15, 2023
* feat: optional client param for history

* feat: prefer smaller random client id & workspace history api

* feat: split keck apis & catch panic if subscribe callback throw

* fix: docs

* feat: webhook for workspace histories

* feat: use default webhook endpoint (#537)

* feat: release subscriber correctly

* fix: lint

---------

Co-authored-by: X1a0t <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants