[18Norway] Only ships are allowed to use harbors #11427
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perwestling
reviewed
Jan 1, 2025
| @@ -453,20 +453,19 @@ def for_graph_city_tokened_by?(city, entity, graph) | |||
| harbor_token?(city, entity) | |||
| end | |||
|
|
|||
| def connected?(a, b, corporation) | |||
| def connected?(a, b, corporation, train) | |||
There was a problem hiding this comment.
"train" might not be a good name of this parameter, as it can be a ship.
How about train_or_ship? Or some other name that includes both? (moveable?)
There was a problem hiding this comment.
I think that naming is fine. The ships are being implemented as Train objects, so it will be a train that is passed as a parameter.
ollybh
added
new games
ollybh
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only ships are allowed to use harbors
Before clicking "Create"
masterpinsorarchive_alpha_gameslabel if this change will break existing gamesdocker compose exec rack rubocop -adocker compose exec rack rakeImplementation Notes
Explanation of Change
Screenshots
Any Assumptions / Hacks