Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1888-N] corrects the Forbidden City private ability #11402

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

philcampeau
Copy link
Collaborator

Fixes #11400

Before clicking "Create"

  • Branch is derived from the latest master
  • Add the pins or archive_alpha_games label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

The Forbidden City private changed between the prototype phase and the final release. The final release version was never implemented. This implements it, but only when playing with the 1888-North variant, since the prototype version is still available for play on the site.

This will require pinning any games using the :north variant.

Screenshots

Any Assumptions / Hacks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1888] A difference between 18xx site and the rule book of 1888
1 participant