Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1840] Cannot pay for track cost as bonus action tobymao#11315 #11336

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

timpelican
Copy link
Contributor

Fixes #11315

Before clicking "Create"

  • Branch is derived from the latest master
  • Add the pins or archive_alpha_games label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

As per notes from @DestrinStorm in issue discussion, the call to lay_tile() from special_track.rb doesn't pass a spender. This means it defaults to trying to spend the money from the tram line, which never has any money to spend, and so will always fail.

The owning major corporation should always pay the cost of a bonus track lay when there is one, the same as it does for any other actions taken by the tram line, e.g. removing / placing tokens.

Fix allows the owning major corp to correctly pay the costs for the bonus yellow tile lay in a hotseat clone of both games flagged in the issue.

Screenshots

Any Assumptions / Hacks

@ollybh ollybh added the 1840 label Nov 11, 2024
@ollybh ollybh merged commit 0e48ef2 into tobymao:master Nov 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1840] Cannot pay for track cost as bonus action
3 participants