[18Uruguay] Also add FCE shares to secondary corps #11209
+26
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollybh
reviewed
Sep 19, 2024
ollybh
requested changes
Oct 6, 2024
|
@patrikolesen This pull request has been open for a while now. Has there been any progress? Just checking that you haven't forgotten about this one… |
|
Thanks for the ping, I will look at this the comming days |
Co-authored-by: Oliver Burnett-Hall <[email protected]>
Co-authored-by: Oliver Burnett-Hall <[email protected]>
Co-authored-by: Oliver Burnett-Hall <[email protected]>
Co-authored-by: Oliver Burnett-Hall <[email protected]>
ollybh
reviewed
Dec 29, 2024
| @@ -28,10 +28,13 @@ def acquire_shares | |||
| entity_shares = affected_shares(holder, @merge_data[:corps]) | |||
|
|
|||
| total_percent = entity_shares.sum(&:percent) | |||
| num_shares, odd_shares = (total_percent / 10).divmod(2) | |||
| from_secondary = @merge_data[:secondary_corps].count { |corp| corp.president?(holder) } | |||
| num_shares = (total_percent / 20).to_i | |||
There was a problem hiding this comment.
@patrikolesen Did you mean to revert this change in this commit? What was rubocop objecting to here? Or was this commit just supposed to remove the space after bundle = below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11111
Fixes #11074
Fixes #[PUT_ISSUE_NUMBER_HERE]
Before clicking "Create"
masterpinsorarchive_alpha_gameslabel if this change will break existing gamesThis can break existing games
docker compose exec rack rubocop -adocker compose exec rack rakeImplementation Notes
Explanation of Change
Screenshots
Any Assumptions / Hacks