Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored CardView exclusion, to support accessor generation for custom Views again #71

Merged
merged 1 commit into from
Feb 23, 2015

Conversation

Buggaboo
Copy link
Contributor

Pull request as usual :)

This is a fix for issue #69.

Thanks!

@tobykurien
Copy link
Owner

Thanks, I'll try this out

tobykurien added a commit that referenced this pull request Feb 23, 2015
Refactored CardView exclusion, to support accessor generation for custom Views again
@tobykurien tobykurien merged commit adf5f76 into tobykurien:v0.12_development Feb 23, 2015
@tobykurien
Copy link
Owner

This doesn't quite work. You will need to include CardView in your test project to see what happens. I've added a catch for ExceptionInInitializer which gets thrown from CardView, but there are other compilation issues that happen which I cannot figure out, e.g. currently I get this: Java problem: The type android.support.v4.app.ActionBarDrawerToggle$DelegateProvider cannot be resolved. It is indirectly referenced from required .class files. This does not happen with previous code.

@Buggaboo
Copy link
Contributor Author

Uhoh. Thanks for the feedback. I'll have another go at it.

Mental note: find time to actually have a go at it (31 mar 2015).

@Buggaboo Buggaboo deleted the v0.12_development branch January 5, 2016 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants