-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@AndroidActivity and @AndroidFragment magic @+id/name -> View name field generation broken for @CustomView(Groups) #69
Comments
I haven't tested this issue yet, but it may be related to a change I made to prevent CardView from crashing the build: 3e5f805 |
Aha, thanks for the heads up. That try catch interrupts my isAssignableFrom. @tobykurien Do you think the isAssignableFrom can be extended to include CardView? Two birds one stone? Two girls one cup? |
IIRC the default constructor of CardView always throws an exception, thus breaking the code. I worked around it by ignoring CardView specifically, i.e. it will not be auto-generated into the code, but is still accessible the old-fashioned way using |
Hey all, |
Thanks, @maannajjar - please send that as a pull request and I'll merge it. I'm also still having issues with cardview and custom views |
A field should be generated on the custom ViewGroup, Fragment and Activity according to the
@+id/name
provided in the layout/viewgroup.xml, also custom Views and ViewGroups.Right now it only works for anything from
android.widget.*
, but not for any other derived types, i.e. custom Views.I recall that the
in the generator code should handle all types deriving from View or ViewGroup.
I'll have a look.
The text was updated successfully, but these errors were encountered: