Skip to content

Commit

Permalink
[GraphQL/Schema] Address Comments from MystenLabs#15252 (MystenLabs#1…
Browse files Browse the repository at this point in the history
…5264)

## Description

I realised I jumped the gun landing MystenLabs#15252 -- I had comments addressed
on it, sitting locally.

## Test Plan

:eyes:
  • Loading branch information
amnn authored Dec 7, 2023
1 parent 1448bbe commit 7feec8d
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 14 deletions.
5 changes: 3 additions & 2 deletions crates/sui-graphql-rpc/schema/current_progress_schema.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -1485,10 +1485,11 @@ type ObjectEdge {

input ObjectFilter {
"""
This field is used to specify the type of objects that should be include in the query
This field is used to specify the type of objects that should be included in the query
results.
Type can be filtered by their package, package::module, or their fuly qualified type name.
Objects can be filtered by their type's package, package::module, or their fully qualified
type name.
Generic types can be queried by either the generic type name, e.g. `0x2::coin::Coin`, or by
the full type name, such as `0x2::coin::Coin<0x2::sui::SUI>`.
Expand Down
16 changes: 8 additions & 8 deletions crates/sui-graphql-rpc/schema/draft_target_schema.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,8 @@ input ObjectFilter {
# This field is used to specify the type of objects that should be
# include in the query results.
#
# Type can be filtered by their package, package::module, or their
# fuly qualified type name.
# Objects can be filtered by their type's package, package::module,
# or their fully qualified type name.
#
# Generic types can be queried by either the generic type name, e.g.
# `0x2::coin::Coin`, or by the full type name, such as
Expand Down Expand Up @@ -330,8 +330,8 @@ input EventFilter {

# This field is used to specify the type of event emitted.
#
# Type can be filtered by their package, package::module, or their
# fuly qualified type name.
# Events can be filtered by their type's package, package::module,
# or their fully qualified type name.
#
# Generic types can be queried by either the generic type name, e.g.
# `0x2::coin::Coin`, or by the full type name, such as
Expand Down Expand Up @@ -383,8 +383,8 @@ input TransactionBlockFilter {
input DynamicFieldFilter {
# Filter the type of dynamic field name.
#
# Type can be filtered by their package, package::module, or their
# fuly qualified type name.
# Names can be filtered by their type's package, package::module, or
# their fully qualified type name.
#
# Generic types can be queried by either the generic type name, e.g.
# `0x2::coin::Coin`, or by the full type name, such as
Expand All @@ -393,8 +393,8 @@ input DynamicFieldFilter {

# Filter the type of dynamic field value.
#
# Type can be filtered by their package, package::module, or their
# fuly qualified type name.
# Values can be filtered by their type's package, package::module,
# or their fully qualified type name.
#
# Generic types can be queried by either the generic type name, e.g.
# `0x2::coin::Coin`, or by the full type name, such as
Expand Down
5 changes: 3 additions & 2 deletions crates/sui-graphql-rpc/src/types/object.rs
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,11 @@ pub(crate) enum ObjectKind {

#[derive(InputObject, Default, Clone)]
pub(crate) struct ObjectFilter {
/// This field is used to specify the type of objects that should be include in the query
/// This field is used to specify the type of objects that should be included in the query
/// results.
///
/// Type can be filtered by their package, package::module, or their fuly qualified type name.
/// Objects can be filtered by their type's package, package::module, or their fully qualified
/// type name.
///
/// Generic types can be queried by either the generic type name, e.g. `0x2::coin::Coin`, or by
/// the full type name, such as `0x2::coin::Coin<0x2::sui::SUI>`.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1489,10 +1489,11 @@ type ObjectEdge {

input ObjectFilter {
"""
This field is used to specify the type of objects that should be include in the query
This field is used to specify the type of objects that should be included in the query
results.

Type can be filtered by their package, package::module, or their fuly qualified type name.
Objects can be filtered by their type's package, package::module, or their fully qualified
type name.

Generic types can be queried by either the generic type name, e.g. `0x2::coin::Coin`, or by
the full type name, such as `0x2::coin::Coin<0x2::sui::SUI>`.
Expand Down

0 comments on commit 7feec8d

Please sign in to comment.