#245: add comments filter #246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lessej
added
feature
In Progress (don't merge)
lessej
removed
the
In Progress (don't merge)
lessej
commented
Sep 18, 2024
| @@ -40,7 +40,9 @@ export const CommentsFilter = () => { | |||
| name="filter" | |||
| id="filter" | |||
| component="textarea" | |||
| placeholder="" | |||
| placeholder="Comments with the phrase..." | |||
| onKeyDown={(e) => e.stopPropagation()} | |||
There was a problem hiding this comment.
This fixes a 'bug' where keyboard navigation would work even when entering text in the text area. The reproduction steps are
- Open the comments popover
- Create a new comment
- Type in the comment filter text area
- Check that keyboard navigation is working
|
@nathanielrindlaub the comment filter should be working to search by phrase and all the PR checks are passing now. Please feel free to review unless you would like some other features to enhance the comments filter. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Implements #245
Add comments filter so users can filter images by the content of comments on the image. Implemented using the
$search$textoperator in MongoDB.https://www.mongodb.com/docs/manual/reference/operator/query/text/#mongodb-query-op.-text
Related PRs
animl-api