Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpret PHOTOMETRIC_MINISWHITE as Gray #134

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkitti
Copy link

@mkitti mkitti commented Nov 23, 2023

This sets the interpretation of PHOTOMETRIC_MINISWHITE to Gray

xref: https://discourse.julialang.org/t/problem-in-reading-tiff-floats-file/106610

Fix #133

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.85%. Comparing base (4613107) to head (77aec0f).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
src/layout.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   91.95%   91.85%   -0.10%     
==========================================
  Files          13       13              
  Lines         920      921       +1     
==========================================
  Hits          846      846              
- Misses         74       75       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlnagy
Copy link
Owner

tlnagy commented Nov 28, 2023

I would be hesitant to merge this PR without JuliaGraphics/ColorTypes.jl#295 being addressed first as we would be violating the Colors.jl promise to faithfully capture the interpretation of the raw data. We could load the data as a standard Gray and ignore the fact that it is supposed to be inverted, but that's inconsistent with how we treat all other interpretations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MethodError: no method matching interpretation(::Val{TiffImages.PHOTOMETRIC_MINISWHITE}), Float32 support
3 participants