Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is likely an esoteric request, but it'd really help us if this entry could be moved to the top of the
package.json
file. A change in Node.js (nodejs/node#50322) moved the package.json resolution logic to C++, pulling in a C++ JSON library called simdjson.This library is now causing ASAN crashes during package.json resolution, but only when
main
is at the end ofpackage.json
. It's more typical for it to be at the top, so this change is slightly more conventional but more importantly will help Electron avoid ASAN crashes as we indirectly depend on this package in our test suite.The ASAN build is broken entirely in Node.js, so this is hitting Electron hard but Node.js itself hasn't surfaced this because Electron's embedded Node.js build works with ASAN where Node.js core does not.
Associate Node.js bug: nodejs/node#55584