Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move main entry to top #51

Merged
merged 1 commit into from
Oct 29, 2024
Merged

chore: move main entry to top #51

merged 1 commit into from
Oct 29, 2024

Conversation

codebytere
Copy link
Contributor

@codebytere codebytere commented Oct 29, 2024

This is likely an esoteric request, but it'd really help us if this entry could be moved to the top of the package.json file. A change in Node.js (nodejs/node#50322) moved the package.json resolution logic to C++, pulling in a C++ JSON library called simdjson.

This library is now causing ASAN crashes during package.json resolution, but only when main is at the end of package.json. It's more typical for it to be at the top, so this change is slightly more conventional but more importantly will help Electron avoid ASAN crashes as we indirectly depend on this package in our test suite.

The ASAN build is broken entirely in Node.js, so this is hitting Electron hard but Node.js itself hasn't surfaced this because Electron's embedded Node.js build works with ASAN where Node.js core does not.

Associate Node.js bug: nodejs/node#55584

package.json Show resolved Hide resolved
@natevw natevw merged commit e9e8ace into tj:master Oct 29, 2024
natevw added a commit that referenced this pull request Oct 29, 2024
@natevw
Copy link
Collaborator

natevw commented Oct 29, 2024

Looks like the real fix (or at least the nodejs/node#55591 workaround) is in progress on the Node.js/ASAN side but this library's own published package was a bit stale w.r.t. the repo here already. So I've gone ahead and published [email protected] including this workaround. Thanks for the detailed notes and cross-references and hope this helps!

@codebytere codebytere deleted the move-main branch October 29, 2024 19:50
@codebytere
Copy link
Contributor Author

@natevw thanks!! appreciated 🙇🏻‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants