Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enabling services with non-standard docker images #237

Merged
merged 2 commits into from
Aug 5, 2021
Merged

Allow enabling services with non-standard docker images #237

merged 2 commits into from
Aug 5, 2021

Conversation

tpetry
Copy link
Contributor

@tpetry tpetry commented Jul 13, 2021

As described in #236 you sometimes want to use non-standard docker images because they have some plugins bundled you may want to use. Especially for PostgreSQL there are a lot of plugins not available in core, the most common is the PostGIS extension.

Instead of simply specifying a simple docker tag in the dialog you can now easily change the base by typing e.g. postgis/postgis:latest. This will also solve the pull request for TimescaleDB as TimescaleDB is just a PostgreSQL extension.

@mattstauffer
Copy link
Member

This is super clever and simple. Thanks @tpetry!

@mattstauffer mattstauffer merged commit 1abbb54 into tighten:main Aug 5, 2021
@mattstauffer
Copy link
Member

@tpetry I just realized--I would love to have a test that covers this. Do you have the time and ability to add one? If not, I'll write it; let me know.

@mattstauffer
Copy link
Member

Hm... I tried your exact code (postgis/postgis:latest) there and it didn't work.

I have a sneaking suspicion that the latest checker doesn't acknowledge your code here.

image

Let me try it with a PostGIS specific tag...

@mattstauffer
Copy link
Member

mattstauffer commented Aug 5, 2021

OK, it works with a PostGIS-specific tag.

So we have a one bug. I should've tried it before merging, but as long as we don't document or announce it I think we're fine:

  1. latest doesn't resolve according to the provided image, it resolves according to the base image.

Is this, plus the test(s), something you can work on @tpetry?

@mattstauffer
Copy link
Member

#244
#245

@tpetry
Copy link
Contributor Author

tpetry commented Aug 5, 2021

I am currently very time constrained, i could work on it in a few weeks.

@tpetry
Copy link
Contributor Author

tpetry commented Aug 5, 2021

Kind of strange that the latest tag does not work, i am kind of sure it did. I see that the algorithm was changed 22 hours ago. Maybe my „hack“ for custom images depended on the implementation? Strange.

@mattstauffer
Copy link
Member

@tpetry OK, I'll try to get to it.

It's also possible that when you tested it, the tag that was "latest" on Postgres also existed on PostGIS, whereas it doesn't anymore.

@mstaack
Copy link

mstaack commented Nov 8, 2021

oh neat, using postgis a lot ! thanks @tpetry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants