-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow enabling services with non-standard docker images #237
Conversation
This is super clever and simple. Thanks @tpetry! |
@tpetry I just realized--I would love to have a test that covers this. Do you have the time and ability to add one? If not, I'll write it; let me know. |
OK, it works with a PostGIS-specific tag. So we have a one bug. I should've tried it before merging, but as long as we don't document or announce it I think we're fine:
Is this, plus the test(s), something you can work on @tpetry? |
I am currently very time constrained, i could work on it in a few weeks. |
Kind of strange that the latest tag does not work, i am kind of sure it did. I see that the algorithm was changed 22 hours ago. Maybe my „hack“ for custom images depended on the implementation? Strange. |
@tpetry OK, I'll try to get to it. It's also possible that when you tested it, the tag that was "latest" on Postgres also existed on PostGIS, whereas it doesn't anymore. |
oh neat, using postgis a lot ! thanks @tpetry |
As described in #236 you sometimes want to use non-standard docker images because they have some plugins bundled you may want to use. Especially for PostgreSQL there are a lot of plugins not available in core, the most common is the PostGIS extension.
Instead of simply specifying a simple docker tag in the dialog you can now easily change the base by typing e.g.
postgis/postgis:latest
. This will also solve the pull request for TimescaleDB as TimescaleDB is just a PostgreSQL extension.