-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
obstacle_stop_planner_refine/include/obstacle_stop_planner/one_step_polygon.hpp
Outdated
Show resolved
Hide resolved
obstacle_stop_planner_refine/include/obstacle_stop_planner/one_step_polygon.hpp
Outdated
Show resolved
Hide resolved
obstacle_stop_planner_refine/include/obstacle_stop_planner/adaptive_cruise_control.hpp
Outdated
Show resolved
Hide resolved
obstacle_stop_planner_refine/include/obstacle_stop_planner/obstacle_point_cloud.hpp
Outdated
Show resolved
Hide resolved
obstacle_stop_planner_refine/include/obstacle_stop_planner/obstacle_point_cloud.hpp
Outdated
Show resolved
Hide resolved
obstacle_stop_planner_refine/include/obstacle_stop_planner/obstacle_point_cloud.hpp
Outdated
Show resolved
Hide resolved
obstacle_stop_planner_refine/include/obstacle_stop_planner/one_step_polygon.hpp
Show resolved
Hide resolved
obstacle_stop_planner_refine/include/obstacle_stop_planner/point_helper.hpp
Show resolved
Hide resolved
obstacle_stop_planner_refine/include/obstacle_stop_planner/trajectory.hpp
Outdated
Show resolved
Hide resolved
obstacle_stop_planner_refine/include/obstacle_stop_planner/util.hpp
Outdated
Show resolved
Hide resolved
obstacle_stop_planner_refine/include/obstacle_stop_planner/util.hpp
Outdated
Show resolved
Hide resolved
obstacle_stop_planner_refine/include/obstacle_stop_planner/util.hpp
Outdated
Show resolved
Hide resolved
obstacle_stop_planner_refine/include/obstacle_stop_planner/vehicle.hpp
Outdated
Show resolved
Hide resolved
bb123aa
to
0427dff
Compare
0427dff
to
d389366
Compare
Codecov Report
@@ Coverage Diff @@
## main #3 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 5 11 +6
Lines 1141 1092 -49
=====================================
+ Misses 1141 1092 -49
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@KeisukeShima Clang-Tidy result is here. Could you please check the warnings and kindly fix the code? tidy-result.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KeisukeShima Could you show me the metrics change calculated by lizard?
obstacle_stop_planner_refine/include/obstacle_stop_planner/adaptive_cruise_control.hpp
Outdated
Show resolved
Hide resolved
obstacle_stop_planner_refine/test/cmake/ament_cmake_auto_gtest-extras.cmake
Outdated
Show resolved
Hide resolved
obstacle_stop_planner_refine/include/obstacle_stop_planner/obstacle_point_cloud.hpp
Outdated
Show resolved
Hide resolved
@kmiya I modified source code to pass clang-tidy. I ignored some warnings because it seems wrong. |
@kenji-miyake You can see metrics report here: https://tier4.github.io/obstacle_stop_planner_refine/pr-check/3-code-metrics.html |
@KeisukeShima I can confirm there are many improvements from the viewpoint of code metrics!
Let's continue to improve more! Left: Before(https://tier4.github.io/obstacle_stop_planner_refine/pr-check/main-code-metrics.html) |
7fef2fe
to
f720dd0
Compare
obstacle_stop_planner_refine/test/src/test_obstacle_stop_planner.cpp
Outdated
Show resolved
Hide resolved
obstacle_stop_planner_refine/test/src/test_obstacle_stop_planner_node.cpp
Outdated
Show resolved
Hide resolved
obstacle_stop_planner_refine/test/obstacle_stop_planner_node_launch_test.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
What kinds of PR
What is this PR
class ObstacleStopPlannerNode
Key input: pathCallback(input/trajectory)
Class diagram
Proposal class diagram
How to check this PR