Merge pull request #41 from tidal-music/feature/major-updates

Updates for Eslint 9

Use alpha version of eslint-typescript 8
Update our one custom rule
Add workaround for eslint-import incompatibility (also needs to install with npm install --force)

.github/workflows/nodejs.yml

@@ -7,7 +7,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [18.x, 20.x]
+        node-version: [18.x, 20.x, 22.x]
     steps:
     - uses: actions/checkout@v4
     - name: Use Node.js ${{ matrix.node-version }}
@@ -16,7 +16,7 @@ jobs:
         node-version: ${{ matrix.node-version }}
     - name: npm install and test
       run: |
-        npm ci
+        npm ci --force
         npm test
       env:
         CI: true

internal-rules/require-coverage-ignore-reason.js

@@ -5,25 +5,38 @@
 // Switched to V8 reporter, with c8 comments.
 // Docs: https://github.com/istanbuljs/v8-to-istanbul#ignoring-uncovered-lines
 
-export function requireCoverageIgnoreReason(context) {
-  const coverageRegExp = /^\s*c8\s+ignore\s+(next|start)\s+/;
-  return {
-    Program() {
-      const sourceCode = context.getSourceCode();
+/**
+ * @type {import("eslint").Rule.RuleModule}
+ */
+export const requireCoverageIgnoreReason = {
+  create: function (context) {
+    const coverageRegExp = /^\s*c8\s+ignore\s+(next|start)\s+/;
+    return {
+      Program() {
+        const sourceCode = context.sourceCode;
 
-      for (const node of sourceCode.getAllComments()) {
-        const comment = node.value;
+        for (const node of sourceCode.getAllComments()) {
+          const comment = node.value;
 
-        if (comment.match(coverageRegExp)) {
-          const reason = comment.replace(coverageRegExp, '');
-          if (reason.length === 0) {
-            context.report({
-              message: 'Add a reason why code coverage should be ignored',
-              node,
-            });
+          if (coverageRegExp.exec(comment)) {
+            const reason = comment.replace(coverageRegExp, '');
+            if (reason.length === 0) {
+              context.report({
+                message: 'Add a reason why code coverage should be ignored',
+                node,
+              });
+            }
           }
         }
-      }
+      },
+    };
+  },
+  meta: {
+    docs: {
+      description: 'Ensure that all coverage ignore comments have a reason',
     },
-  };
-}
+    fixable: 'code',
+    schema: [], // no options
+    type: 'suggestion',
+  },
+};