Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "feat: add label in case of conflict (#652)" #654

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

Rustin170506
Copy link
Contributor

This reverts commit a168b92

Signed-off-by: hi-rustin [email protected]

@ti-chi-bot ti-chi-bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Jul 21, 2021
@ti-chi-bot ti-chi-bot requested a review from Mini256 July 21, 2021 03:27
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 21, 2021
@github-actions
Copy link

github-actions bot commented Jul 21, 2021

🎊 PR Preview 74df7e1 has been successfully built and deployed to https://ti-community-infra-tichi-preview-pr-654.surge.sh

🕐 Build time: 0.015s

🤖 By surge-preview

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #654 (74df7e1) into master (6e5814c) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #654      +/-   ##
==========================================
+ Coverage   80.25%   80.35%   +0.09%     
==========================================
  Files          17       17              
  Lines        2345     2341       -4     
==========================================
- Hits         1882     1881       -1     
+ Misses        306      304       -2     
+ Partials      157      156       -1     
Impacted Files Coverage Δ
...l/pkg/externalplugins/cherrypicker/cherrypicker.go 61.90% <ø> (+0.34%) ⬆️
internal/pkg/externalplugins/label.go 71.42% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e5814c...74df7e1. Read the comment docs.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Mini256

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 21, 2021
@Rustin170506
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 74df7e1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 21, 2021
@lance6716
Copy link

what happened 😂

@Rustin170506
Copy link
Contributor Author

what happened 😂

See: #539 (comment)

@Rustin170506 Rustin170506 deleted the rustin-patch-fix branch July 21, 2021 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants