Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revert rerere component #613

Merged
merged 12 commits into from
Jun 29, 2021

Conversation

Rustin170506
Copy link
Contributor

@Rustin170506 Rustin170506 commented Jun 24, 2021

Since the status of the tide can now be set to required, this may be an effective solution.

@ti-chi-bot ti-chi-bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Jun 24, 2021
@ti-chi-bot ti-chi-bot requested a review from Mini256 June 24, 2021 13:14
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 24, 2021
@github-actions
Copy link

github-actions bot commented Jun 24, 2021

🎊 PR Preview 42172de has been successfully built and deployed to https://ti-community-infra-tichi-preview-pr-613.surge.sh

🕐 Build time: 0.012s

🤖 By surge-preview

@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #613 (42172de) into master (b53208e) will decrease coverage by 0.29%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #613      +/-   ##
==========================================
- Coverage   78.82%   78.52%   -0.30%     
==========================================
  Files          16       17       +1     
  Lines        2035     2119      +84     
==========================================
+ Hits         1604     1664      +60     
- Misses        286      302      +16     
- Partials      145      153       +8     
Impacted Files Coverage Δ
internal/pkg/rerere/rerere.go 71.42% <71.42%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b53208e...42172de. Read the comment docs.

@Rustin170506
Copy link
Contributor Author

@Mini256 ping~ Could you please take a look?

@Mini256
Copy link
Member

Mini256 commented Jun 28, 2021

@Mini256 ping~ Could you please take a look?

😢 Sorry, I'm delayed by devstats. I'll review it later after the metric test running.

docs/components/rerere.md Outdated Show resolved Hide resolved
docs/components/rerere.md Outdated Show resolved Hide resolved
cmd/rerere/main.go Outdated Show resolved Hide resolved
docs/components/rerere.md Outdated Show resolved Hide resolved
internal/pkg/rerere/rerere.go Outdated Show resolved Hide resolved
internal/pkg/rerere/rerere.go Outdated Show resolved Hide resolved
internal/pkg/rerere/rerere.go Outdated Show resolved Hide resolved
internal/pkg/rerere/rerere.go Outdated Show resolved Hide resolved
internal/pkg/rerere/rerere.go Outdated Show resolved Hide resolved
internal/pkg/rerere/rerere.go Show resolved Hide resolved
Copy link
Member

@Mini256 Mini256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need English documentation.

@Rustin170506
Copy link
Contributor Author

Also need English documentation.

I have no time to add it. So add an item in #423

Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
@Rustin170506 Rustin170506 requested a review from Mini256 June 29, 2021 03:04
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Mini256

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 29, 2021
@Mini256
Copy link
Member

Mini256 commented Jun 29, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 42172de

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 29, 2021
@ti-chi-bot ti-chi-bot merged commit f6cbbe4 into ti-community-infra:master Jun 29, 2021
@Rustin170506
Copy link
Contributor Author

@Mini256 Thanks a lot!

@Rustin170506 Rustin170506 deleted the rustin-patch-feat branch June 29, 2021 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants