Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add prow plugins document #466

Merged
merged 23 commits into from
Apr 9, 2021

Conversation

634750802
Copy link
Contributor

@634750802 634750802 commented Apr 6, 2021

part of #423

close #426
close #408
close #465

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Apr 6, 2021
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 6, 2021
@ti-chi-bot
Copy link
Member

Hi @634750802. Thanks for your PR.

I'm waiting for a ti-community-infra member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Apr 6, 2021
@github-actions
Copy link

github-actions bot commented Apr 6, 2021

🎊 PR Preview 66e564a has been successfully built and deployed to https://ti-community-infra-tichi-preview-pr-466.surge.sh

🕐 Build time: 0.016s

🤖 By surge-preview

@634750802
Copy link
Contributor Author

/cc @hi-rustin

@Rustin170506
Copy link
Contributor

Thank you for your contribution, but the format and content of these documents are not quite right, you can refer to hold's documentation and other documents to see how to add these documents.

@Rustin170506 Rustin170506 changed the title doc: add prow plugin document docs: add prow plugin document Apr 6, 2021
@634750802 634750802 changed the title docs: add prow plugin document WIP docs: add prow plugin document Apr 7, 2021
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2021
@634750802 634750802 changed the title WIP docs: add prow plugin document docs: add prow plugin document Apr 7, 2021
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2021
docs/plugins/assign.md Outdated Show resolved Hide resolved
docs/plugins/assign.md Outdated Show resolved Hide resolved
docs/plugins/assign.md Outdated Show resolved Hide resolved
docs/plugins/milestone.md Outdated Show resolved Hide resolved
@634750802 634750802 requested a review from Rustin170506 April 7, 2021 07:51
@Rustin170506
Copy link
Contributor

/ok-to-test

/assign @Mini256

PTAL~ Thanks!

@Rustin170506
Copy link
Contributor

/hold

Waiting for @Mini256 approve.

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2021
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #466 (66e564a) into master (ba09357) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #466   +/-   ##
=======================================
  Coverage   81.12%   81.12%           
=======================================
  Files          16       16           
  Lines        1875     1875           
=======================================
  Hits         1521     1521           
  Misses        216      216           
  Partials      138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba09357...66e564a. Read the comment docs.

@Rustin170506 Rustin170506 changed the title docs: add prow plugin document docs: add prow plugins document Apr 7, 2021
@Rustin170506
Copy link
Contributor

@634750802 Could you please translate these docs by https://www.deepl.com/translator?

docs/_sidebar.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 9, 2021
Copy link
Contributor

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the content is great. Thanks! There are still a few minor issues that need to be fixed.

docs/_sidebar.md Outdated Show resolved Hide resolved
docs/en/_sidebar.md Outdated Show resolved Hide resolved
docs/en/plugins/assign.md Outdated Show resolved Hide resolved
docs/en/plugins/milestone.md Outdated Show resolved Hide resolved
docs/en/plugins/size.md Outdated Show resolved Hide resolved
@Rustin170506
Copy link
Contributor

/unhold

/lgtm

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 9, 2021
@Rustin170506
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 66e564a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 9, 2021
@Rustin170506
Copy link
Contributor

@634750802 Great! Thanks again for your contribution!

@ti-chi-bot ti-chi-bot merged commit 561b478 into ti-community-infra:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. ok-to-test Indicates a PR is ready to be tested. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
4 participants