Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notice): remove articleCommentPinned setting #4594

Merged
merged 2 commits into from
Jun 24, 2024
Merged

feat(notice): remove articleCommentPinned setting #4594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c6d285
feat(notice): remove `articleCommentPinned` setting
gary02 Jun 24, 2024
2a77703
Merge branch 'develop' into feat/selected-comment-notice
gary02 Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lang/default.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2327,10 +2327,6 @@
"gS1u3d": {
"defaultMessage": "{left} modifications available"
},
"gW/KWu": {
"defaultMessage": "Comments has been pinned",
"description": "src/views/Me/Settings/Notifications/GeneralSettings/index.tsx"
},
"gczcC5": {
"defaultMessage": "Subscribe"
},
Expand Down
4 changes: 0 additions & 4 deletions lang/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2327,10 +2327,6 @@
"gS1u3d": {
"defaultMessage": "{left} modifications available"
},
"gW/KWu": {
"defaultMessage": "Comments has been pinned",
"description": "src/views/Me/Settings/Notifications/GeneralSettings/index.tsx"
},
"gczcC5": {
"defaultMessage": "Subscribe"
},
Expand Down
4 changes: 0 additions & 4 deletions lang/zh-Hans.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2327,10 +2327,6 @@
"gS1u3d": {
"defaultMessage": "你还可以修改 {left} 次"
},
"gW/KWu": {
"defaultMessage": "评论被精选",
"description": "src/views/Me/Settings/Notifications/GeneralSettings/index.tsx"
},
"gczcC5": {
"defaultMessage": "订阅"
},
Expand Down
4 changes: 0 additions & 4 deletions lang/zh-Hant.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2327,10 +2327,6 @@
"gS1u3d": {
"defaultMessage": "你還可以修改 {left} 次"
},
"gW/KWu": {
"defaultMessage": "評論被精選",
"description": "src/views/Me/Settings/Notifications/GeneralSettings/index.tsx"
},
"gczcC5": {
"defaultMessage": "訂閱"
},
Expand Down
27 changes: 0 additions & 27 deletions src/views/Me/Settings/Notifications/GeneralSettings/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ const VIEWER_NOTIFICATIONS_GENERAL_SETTINGS = gql`
articleNewComment
articleNewAppreciation
articleNewSubscription
articleCommentPinned
articleNewCollected
}
}
Expand All @@ -47,7 +46,6 @@ const UPDATE_VIEWER_NOTIFICATIONS_GENERAL = gql`
articleNewComment
articleNewAppreciation
articleNewSubscription
articleCommentPinned
articleNewCollected
}
}
Expand Down Expand Up @@ -245,31 +243,6 @@ const NotificationsGeneralSettings = () => {
/>
}
/>

{/* Comments has been pinned */}
<TableView.Cell
title={
<FormattedMessage
defaultMessage="Comments has been pinned"
id="gW/KWu"
description="src/views/Me/Settings/Notifications/GeneralSettings/index.tsx"
/>
}
right={
<Switch
name="nofitication-comment-pinned"
label={
<FormattedMessage
defaultMessage="Comments has been pinned"
id="gW/KWu"
description="src/views/Me/Settings/Notifications/GeneralSettings/index.tsx"
/>
}
checked={settings.articleCommentPinned}
onChange={() => toggle('articleCommentPinned')}
/>
}
/>
</TableView>

<Email toggle={toggle} settings={settings} />
Expand Down
Loading