Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise pathname of article detail page #4196

Closed
robertu7 opened this issue Feb 21, 2024 · 0 comments · Fixed by #4315
Closed

Revise pathname of article detail page #4196

robertu7 opened this issue Feb 21, 2024 · 0 comments · Fixed by #4315
Assignees
@robertu7 @tx0c

Comments

@robertu7
Copy link
Contributor

robertu7 commented Feb 21, 2024 •
edited
Loading

Checklist

Story
@robertu7 robertu7 mentioned this issue Feb 21, 2024
Closed
@zeckli zeckli mentioned this issue Feb 6, 2024
Open
tx0c added a commit that referenced this issue Mar 5, 2024
@tx0c
feat(new-article-path): Revise pathname of article detail page #4196
08f2a03 
for #4196
@tx0c tx0c mentioned this issue Mar 5, 2024
Closed
tx0c added a commit that referenced this issue Mar 5, 2024
@tx0c
feat(new-article-path): Revise pathname of article detail page #4196
8255200 
for #4196
tx0c added a commit that referenced this issue Mar 5, 2024
@tx0c
feat(new-article-path): Revise pathname of article detail page #4196
fdd28a2 
for #4196
tx0c added a commit that referenced this issue Mar 5, 2024
@tx0c
feat(new-article-path): Revise pathname of article detail page #4196
df6f23e 
for #4196
@tx0c tx0c mentioned this issue Mar 5, 2024
Closed
tx0c added a commit that referenced this issue Mar 5, 2024
@tx0c
feat(new-article-path): Revise pathname of article detail page #4196
5721de2 
for #4196
tx0c added a commit that referenced this issue Mar 5, 2024
@tx0c
feat(new-article-path): Revise pathname of article detail page #4196
d942e18 
for #4196
tx0c added a commit that referenced this issue Mar 6, 2024
@tx0c
feat(new-article-path): Revise pathname of article detail page #4196
c2847f1 
for #4196
tx0c added a commit that referenced this issue Mar 12, 2024
@tx0c
feat(new-article-path): Revise pathname of article detail page #4196
03e40e9 
for #4196
tx0c added a commit that referenced this issue Mar 12, 2024
@tx0c
feat(new-article-path): Revise pathname of article detail page #4196
7eadbec 
for #4196
@tx0c tx0c mentioned this issue Mar 12, 2024
Closed
tx0c added a commit that referenced this issue Mar 12, 2024
@tx0c
feat(new-article-path): Revise pathname of article detail page #4196
5b82461 
for #4196
tx0c pushed a commit that referenced this issue Apr 29, 2024
feat(new-article-path): Revise pathname of article detail page #4196
fc6bce9 
for #4196
tx0c pushed a commit that referenced this issue Apr 29, 2024
feat(new-article-path): Revise pathname of article detail page #4196
c591685 
for #4196
tx0c pushed a commit that referenced this issue Apr 29, 2024
feat(new-article-path): Revise pathname of article detail page #4196
f65499b 
for #4196
@tx0c tx0c mentioned this issue Apr 29, 2024
Merged
tx0c pushed a commit to thematters/lambda-handlers that referenced this issue Apr 29, 2024
feat(fill-short-hash): migrate back-fill short_hash for old existing …
50d4a44 
…articles

the migrate for thematters/matters-web#4196 ; not in matters-server is for
using the `UPDATE ... FROM UNNEST(...)` batch updating syntax much more efficient,
and which is not in knex-2.4 by matters-server yet;

```console
$ time PGIDLE_TIMEOUT=5 PGPASSWORD='xxx' \
    PG_CONNECTION_STRING='postgresql://[email protected]/database' \
    BATCH_SIZE=3200 \
    node --trace-warnings ./dist/bin/fill-short-hash.js
debug: query --:

      select b.oid, b.typarray
      from pg_catalog.pg_type a
      left join pg_catalog.pg_type b on b.oid = a.typelem
      where a.typcategory = 'A'
      group by b.oid, b.typarray
      order by b.oid

 { connection: 2, params: [], types: [] }
debug: query --:
SELECT (short_hash IS NOT NULL) short_hash, COUNT(*) ::int FROM public.article GROUP BY 1 ;
 { connection: 2, params: [], types: [] }
2024-04-29T07:07:19.530Z get stats: Result(1) [ { shortHash: true, count: 584509 } ]
debug: query --:
ALTER TABLE article ALTER COLUMN short_hash SET NOT NULL ;
 { connection: 2, params: [], types: [] }
[...]
```
tx0c pushed a commit that referenced this issue Apr 29, 2024
feat(new-article-path): Revise pathname of article detail page #4196
59eb9d3 
for #4196
tx0c pushed a commit that referenced this issue Apr 29, 2024
feat(new-article-path): Revise pathname of article detail page #4196
6e06a71 
for #4196
tx0c pushed a commit that referenced this issue Apr 29, 2024
feat(new-article-path): Revise pathname of article detail page #4196
17fb7e1 
for #4196
tx0c pushed a commit to thematters/lambda-handlers that referenced this issue Apr 29, 2024
feat(fill-short-hash): migrate back-fill short_hash for old existing …
5b95972 
…articles

the migrate for thematters/matters-web#4196 ; not in matters-server is for
using the `UPDATE ... FROM UNNEST(...)` batch updating syntax much more efficient,
and which is not in knex-2.4 by matters-server yet;

```console
$ time PGIDLE_TIMEOUT=5 PGPASSWORD='xxx' \
    PG_CONNECTION_STRING='postgresql://[email protected]/database' \
    BATCH_SIZE=3200 \
    node --trace-warnings ./dist/bin/fill-short-hash.js
debug: query --:

      select b.oid, b.typarray
      from pg_catalog.pg_type a
      left join pg_catalog.pg_type b on b.oid = a.typelem
      where a.typcategory = 'A'
      group by b.oid, b.typarray
      order by b.oid

 { connection: 2, params: [], types: [] }
debug: query --:
SELECT (short_hash IS NOT NULL) short_hash, COUNT(*) ::int FROM public.article GROUP BY 1 ;
 { connection: 2, params: [], types: [] }
2024-04-29T07:07:19.530Z get stats: Result(1) [ { shortHash: true, count: 584509 } ]
debug: query --:
ALTER TABLE article ALTER COLUMN short_hash SET NOT NULL ;
 { connection: 2, params: [], types: [] }
[...]
```
@tx0c tx0c mentioned this issue Apr 29, 2024
Merged
tx0c pushed a commit that referenced this issue Apr 30, 2024
feat(new-article-path): Revise pathname of article detail page #4196
9516558 
for #4196
tx0c pushed a commit that referenced this issue Apr 30, 2024
feat(new-article-path): Revise pathname of article detail page #4196
ab67cc9 
for #4196
tx0c pushed a commit that referenced this issue Apr 30, 2024
feat(new-article-path): Revise pathname of article detail page #4196
484c2b9 
for #4196
@robertu7 robertu7 mentioned this issue May 2, 2024
Merged
@robertu7 robertu7 self-assigned this May 2, 2024
@robertu7 robertu7 linked a pull request May 2, 2024 that will close this issue
feat(article): use shortHash as query input #4315
Merged
@robertu7 robertu7 mentioned this issue May 7, 2024
Merged
tx0c pushed a commit to thematters/lambda-handlers that referenced this issue May 22, 2024
feat(fill-short-hash): migrate back-fill short_hash for old existing …
65eb73b 
…articles

the migrate for thematters/matters-web#4196 ; not in matters-server is for
using the `UPDATE ... FROM UNNEST(...)` batch updating syntax much more efficient,
and which is not in knex-2.4 by matters-server yet;

```console
$ time PGIDLE_TIMEOUT=5 PGPASSWORD='xxx' \
    PG_CONNECTION_STRING='postgresql://[email protected]/database' \
    BATCH_SIZE=3200 \
    node --trace-warnings ./dist/bin/fill-short-hash.js
debug: query --:

      select b.oid, b.typarray
      from pg_catalog.pg_type a
      left join pg_catalog.pg_type b on b.oid = a.typelem
      where a.typcategory = 'A'
      group by b.oid, b.typarray
      order by b.oid

 { connection: 2, params: [], types: [] }
debug: query --:
SELECT (short_hash IS NOT NULL) short_hash, COUNT(*) ::int FROM public.article GROUP BY 1 ;
 { connection: 2, params: [], types: [] }
2024-04-29T07:07:19.530Z get stats: Result(1) [ { shortHash: true, count: 584509 } ]
debug: query --:
ALTER TABLE article ALTER COLUMN short_hash SET NOT NULL ;
 { connection: 2, params: [], types: [] }
[...]
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertu7 robertu7

@tx0c tx0c

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(article): use shortHash as query input thematters/matters-web
2 participants
@robertu7 @tx0c