feat(fill-short-hash): migrate back-fill short_hash for old existing … #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gary02
approved these changes
May 10, 2024
| SET short_hash=last_batch_with_hash.short_hash | ||
| FROM last_batch_with_hash | ||
| WHERE article.id=last_batch_with_hash.id | ||
| RETURNING article.* ; ` |
There was a problem hiding this comment.
can only return "article.id" ?
tx0c
force-pushed
the
feat/fill-short-hash
branch
from
5b95972 to
65eb73b
Compare
…articles the migrate for thematters/matters-web#4196 ; not in matters-server is for using the `UPDATE ... FROM UNNEST(...)` batch updating syntax much more efficient, and which is not in knex-2.4 by matters-server yet; ```console $ time PGIDLE_TIMEOUT=5 PGPASSWORD='xxx' \ PG_CONNECTION_STRING='postgresql://[email protected]/database' \ BATCH_SIZE=3200 \ node --trace-warnings ./dist/bin/fill-short-hash.js debug: query --: select b.oid, b.typarray from pg_catalog.pg_type a left join pg_catalog.pg_type b on b.oid = a.typelem where a.typcategory = 'A' group by b.oid, b.typarray order by b.oid { connection: 2, params: [], types: [] } debug: query --: SELECT (short_hash IS NOT NULL) short_hash, COUNT(*) ::int FROM public.article GROUP BY 1 ; { connection: 2, params: [], types: [] } 2024-04-29T07:07:19.530Z get stats: Result(1) [ { shortHash: true, count: 584509 } ] debug: query --: ALTER TABLE article ALTER COLUMN short_hash SET NOT NULL ; { connection: 2, params: [], types: [] } [...] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…articles
the migrate for thematters/matters-web#4196 ; not in matters-server is for using the
UPDATE ... FROM UNNEST(...)batch updating syntax much more efficient, and which is not in knex-2.4 by matters-server yet;