Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(report-comment): auto collapse reported comment conditionally #3912

Merged
merged 1 commit into from
May 15, 2024
Merged

feat(report-comment): auto collapse reported comment conditionally #3912

merged 1 commit into from
May 15, 2024

Conversation

gary02
Copy link
Contributor

@gary02 gary02 commented May 15, 2024

re #3911

@gary02 gary02 requested a review from a team as a code owner May 15, 2024 07:45
@gary02 gary02 linked an issue May 15, 2024 that may be closed by this pull request
Auto-collapse reported comment #3911
Closed
2 tasks
@codecov Codecov
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 58.52%. Comparing base (03047bb) to head (b8ddcbb).
Report is 2 commits behind head on develop.

Files Patch % Lines
src/connectors/systemService.ts 10.00% 18 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3912      +/-   ##
===========================================
- Coverage    58.57%   58.52%   -0.05%     
===========================================
  Files          883      884       +1     
  Lines        17244    17270      +26     
  Branches      3093     3098       +5     
===========================================
+ Hits         10101    10108       +7     
- Misses        7092     7111      +19     
  Partials        51       51

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

robertu7
robertu7 approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@robertu7 robertu7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gary02 gary02 merged commit e6f75ba into develop May 15, 2024
2 of 4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/report-comment branch May 15, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertu7 robertu7 robertu7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-collapse reported comment
2 participants
@gary02 @robertu7