Replace superagent with fetch library wide
#492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also does the following. - All responses return a `Headers` object instead of a plain object, matching the behavior of the underlying `fetch` calls. - Updates all test mocking to use `jest-fetch-mock`. - Cleans up unneeded development dependencies.
eligundry
force-pushed
the
convert-to-fetch
branch
from
8eef88b to
13e68f5
Compare
|
Thank you for making this and setting it up as its package! Totally necessary for getting this working with Cloudflare |
|
Recently, I began the transition to spotify-web-api-ts-sdk, as I encountered issues where requests would hang indefinitely without any timeouts being triggered. However, I quickly realized that the repository was still in the early stages of development. Imagine my delight upon discovering this Pull Request! A heartfelt thank you to @eligundry for your invaluable contributions. Your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fetchfunction.fetchfunction or has afetchpolyfill installed.Headersobject instead of a plain object, matching the behavior of the underlyingfetchcalls.jest-fetch-mock.Note to reviewer
@thelinmichael I know that this is a big pull request and it seems that you have stepped away from this project, but I would encourage you to take this seriously. I am heavily invested in the Spotify API and would love to step up and help maintain this library, as Spotify links to this library in their documentation. If you truly are not interested in maintaining this project and are going to ignore this, I am going to merge this into its own namespace (probably
spotify-web-api-fetch) and just keep running with this. Just please let us know what the status of this project is.Closes #491