Remove enum Versions.Major, replacing all usages with Semver4j #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes pattern - handles non-existant build directory - reduces some method visibilities - adds dummy jar files for testing against
patch by Mick Semb Wever; reviewed by XXX for XXX
michaelsembwever
added a commit
to thelastpickle/cassandra
that referenced
this pull request
May 17, 2021
michaelsembwever
force-pushed
the
mck/semver4j
branch
from
73144c0 to
2057dbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the Semver4j introduction all the way in making the
Semverclass part of the API, and replacing 'Versions.Major' enum with it.fyi @ifesdjeen