Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #37212 - Drop foreman_setup plugin support #1155

Merged
merged 1 commit into from
May 8, 2024
Merged

Refs #37212 - Drop foreman_setup plugin support #1155

merged 1 commit into from
May 8, 2024

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Feb 28, 2024

No description provided.

@ekohl
Copy link
Member Author

ekohl commented Feb 28, 2024

Puppet 8.5.0 / 7.29.0 strikes again:

Could not parse for environment *root*: The parameter '$request_timeout' must be a literal type, not a Puppet::Pops::Model::AccessExpression (file: /home/runner/work/puppet-foreman/puppet-foreman/manifests/cli.pp, line: 36, column: 15)

@ekohl ekohl force-pushed the 37212-drop-foreman_setup branch from 20734a4 to b2ebb2e Compare May 7, 2024 17:45
@ekohl
Copy link
Member Author

ekohl commented May 7, 2024

Trivial rebase to kick off CI again.

@evgeni evgeni merged commit 66e6569 into theforeman:master May 8, 2024
16 of 17 checks passed
@ekohl ekohl deleted the 37212-drop-foreman_setup branch May 8, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeni evgeni evgeni approved these changes

Assignees
No one assigned
Labels
Backwards incompatible Waiting on contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekohl @evgeni