-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Puppet 8 support #1126
Add Puppet 8 support #1126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI needs to be updated for it to run tests on Puppet 8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs #1133 so it actually runs CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all fixes are in place. Please rebase.
The `ensure_packages()` function is deprecated. The successor is `stdlib::ensure_packages().
I did notice there were deprecation warnings about the ERB template:
This needs to use keyword arguments now (and is repeated in multiple files). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failure is relevant. I think the exception needs to be changed to a general Puppet::Error
instead of a ParseError
.
I think #1139 should be complete. I've opted to drop the deprecated non-namespaced functions instead of trying to fix them. |
also contains #1125