Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one check job for updates on automation/requirements.txt #1102

Conversation

Odilhao
Copy link
Member

@Odilhao Odilhao commented Aug 2, 2024

No description provided.

@Odilhao Odilhao force-pushed the rpm/develop-ci-improve-requirement-check branch 2 times, most recently from a29d9e7 to c2c710f Compare August 2, 2024 15:39
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to make rpm_list depend on check_resolution (via needs: check_resolution)?

@Odilhao
Copy link
Member Author

Odilhao commented Aug 2, 2024

Would it make sense to make rpm_list depend on check_resolution (via needs: check_resolution)?

Yes, it does make sense to wait on check_resolution.

@Odilhao Odilhao force-pushed the rpm/develop-ci-improve-requirement-check branch from c2c710f to e4c49bd Compare August 2, 2024 16:02
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last thought: would this workflow work if you also ran it when .github/workflows/requirement-check.yml itself changes? Sort of implementing CI for your CI.

@Odilhao
Copy link
Member Author

Odilhao commented Aug 2, 2024

Last thought: would this workflow work if you also ran it when .github/workflows/requirement-check.yml itself changes? Sort of implementing CI for your CI.

For that to happen we need to change this conditional

- 'automation/requirements.txt'

Let me send the change

@Odilhao Odilhao force-pushed the rpm/develop-ci-improve-requirement-check branch from e4c49bd to dfa24f9 Compare August 2, 2024 16:07
@ekohl
Copy link
Member

ekohl commented Aug 2, 2024

For that to happen we need to change this conditional

Exactly what I had in mind. And we immediately see it fail, so it's "working" :)

@Odilhao Odilhao force-pushed the rpm/develop-ci-improve-requirement-check branch from dfa24f9 to b320221 Compare August 2, 2024 16:09
@Odilhao
Copy link
Member Author

Odilhao commented Aug 2, 2024

 ERROR: Cannot install -r automation/requirements.txt (line 1) and pulp-glue==0.27.1 because these package versions have conflicting dependencies.
The conflict is caused by:
    The user requested pulp-glue==0.27.1
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
    pulpcore 3.49.15 depends on pulp-glue<0.26 and >=0.18.0
To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

I consider this a win, it's working!

@Odilhao Odilhao merged commit e9efd37 into theforeman:rpm/develop Aug 2, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants