Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop wait.yml and put waiting code in each respective build type #397

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Oct 28, 2024

The logic for how to wait on a task to build across the different build types supported has diverged to the point where a separate file is more confusing than it is helpful in understanding the code logic.

@ehelms
Copy link
Member Author

ehelms commented Oct 29, 2024

Failing 3.6/3.7/3.8 is expected due to pylint.

The logic for how to wait on a task to build across the different
build types supported has diverged to the point where a separate file
is more confusing than it is helpful in understanding the code logic.

Signed-off-by: Eric D. Helms <[email protected]>
@ehelms ehelms force-pushed the refactor-wait-tasks branch from f6c6746 to 5becf5a Compare October 29, 2024 15:02
@ehelms ehelms merged commit 70af61f into theforeman:master Oct 29, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants