Fix foreman_provisioning role #1866

adamruzicka · 2024-10-17T13:31:51Z

The role expects that the user has community.libvirt role installed. With these changes, the role should at least pass.

sjha4 · 2024-11-21T17:16:08Z

I ran into this when running this playbook:

Thursday 21 November 2024  11:32:58 -0500 (0:00:00.017)       0:08:41.550 ***** 
 [started TASK: foreman_provisioning : create hostgroup Base on ip-10-0-167-217.rhos-01.prod.psi.rdu2.redhat.com]

TASK [foreman_provisioning : create hostgroup Base] **********************************************************************************************
fatal: [ip-10-0-167-217.rhos-01.prod.psi.rdu2.redhat.com]: FAILED! => changed=true 
  cmd: |-
    hammer hostgroup create --name 'Base' --architecture x86_64 --domain example.com --puppet-environment production --puppet-ca-proxy-id 1 --puppet-proxy-id 1 --subnet '192.168.73.0/24' --compute-profile libvirt-profile --compute-resource libvirt --root-pass changeme --pxe-loader "PXELinux BIOS" --organization 'Default Organization' --organizations 'Default Organization' --locations 'Default Location'
  delta: '0:00:00.810490'
  end: '2024-11-21 11:32:59.718525'
  msg: non-zero return code
  rc: 64
  start: '2024-11-21 11:32:58.908035'
  stderr: |-
    Could not create the hostgroup:
      Error: Unrecognised option '--root-pass'.
  
      See: 'hammer hostgroup create --help'.
  stderr_lines: <omitted>
  stdout: ''
  stdout_lines: <omitted>

ekohl

In 5592157 we rewrote the CentOS parts to FAM. I had hoped the other distros would also get done. Is this a good excuse to clean them up into sustainable code? I'd imagine people might actually use it as reference code.

ekohl · 2024-11-21T18:43:27Z

roles/foreman_provisioning/tasks/main.yml

-    --medium '{{ centos_medium_name }}'
+    --name 'CentOS 9 Mirror'
+    --operatingsystem 'CentOS_Stream 9'
+    --medium 'CentOS Stream 9 mirror'


In theforeman/foreman#10227 I'd like to rename this again to the generic CentOS mirror so I think the variable still makes sense.

roles/foreman_provisioning/tasks/configure_ubuntu_24_04.yml

ekohl · 2024-11-27T23:45:51Z

roles/foreman_provisioning/tasks/configure_debian_12_7.yml

Would this work as a replacement for the Hammer stuff?

- name: "Ensure Debian 12" # noqa: args[module] theforeman.foreman.operatingsystem: name: Debian family: Debian major: 12 minor: 7 release_name: Bookworm architectures: - x86_64 media: - Debian mirror provisioning_templates: - Preseeed default ptables: - Preseed default state: present - name: "Set default template for Debian 12" # noqa: args[module] theforeman.foreman.os_default_template: operatingsystem: "Debian 12" template_kind: "provision" provisioning_template: "Preseed default" state: present

Almost, if I'm reading it correctly, the current hammer-based implementation associates all templates which start with "Preseed default" with the os. This one associates just the ones which are explicitly listed? Unless I'm missing something, fam doesn't really give us options to list with search and the reuse the result so I'd have to fallback to a mix of hammer and this to associate all the relevant templates?

I've also often wondered how we can make this better. We already know the operating systems that are compatible (since the template lists them) so should Foreman have some option to automatically associate all compatible options? And by that I mean server side, without having to specify them.

@evgeni any thoughts on this?

FAM can do searches (I can drop you an example if you want), but yeah, automatic in Foreman would be cooler

I can drop you an example if you want

If you'd indulge me

Untested:

- name: "Find all preseed templates" theforeman.foreman.resource_info: resource: provisioning_templates search: name ~ "Preseed default" register: result - name: "Set default template for Debian 12" # noqa: args[module] theforeman.foreman.os_default_template: operatingsystem: "Debian 12" template_kind: "{{ item.template_kind_name }}" provisioning_template: "{{ item.name }}" state: present loop: "{{ result.resources }}"

But now I wonder, how should an OS have multiple default templates of the same kind?

Well, not of the same kind. The search should return several templates of different kinds. It would be nice to not have to do this https://github.com/theforeman/forklift/pull/1885/files

Right! Updated the snippet above to do that, can you try it?

Mhh, but it'd still be a problem for PXE* ones, as there are two of them? 🤔

{ "created_at": "2024-09-04 05:14:23 UTC", "description": "The template to render Grub2 bootloader configuration for preseed based distributions.\nThe output is deployed on the host's subnet TFTP proxy.", "id": 9, "name": "Preseed default PXEGrub2", "snippet": false, "template_kind_id": 4, "template_kind_name": "PXEGrub2", "updated_at": "2024-09-04 05:14:23 UTC" }, { "created_at": "2024-09-04 05:14:23 UTC", "description": null, "id": 10, "name": "Preseed default PXEGrub2 Autoinstall", "snippet": false, "template_kind_id": 4, "template_kind_name": "PXEGrub2", "updated_at": "2024-09-04 05:14:23 UTC" }, { "created_at": "2024-09-04 05:14:23 UTC", "description": "The template to render PXELinux bootloader configuration for preseed based distributions.\nThe output is deployed on the host's subnet TFTP proxy.", "id": 19, "name": "Preseed default PXELinux", "snippet": false, "template_kind_id": 2, "template_kind_name": "PXELinux", "updated_at": "2024-09-04 05:14:23 UTC" }, { "created_at": "2024-09-04 05:14:23 UTC", "description": null, "id": 20, "name": "Preseed default PXELinux Autoinstall", "snippet": false, "template_kind_id": 2, "template_kind_name": "PXELinux", "updated_at": "2024-09-04 05:14:23 UTC" },

evgeni · 2024-12-03T12:25:25Z

roles/foreman_provisioning/tasks/configure_ubuntu_24_04.yml

+    template_kind: "{{ item.template_kind_name }}"
+    provisioning_template: "{{ item.name }}"
+    state: present
+  loop: "{{ result.resources | sort(attribute='name') | unique(attribute='template_kind_name') }}"


I think Ubuntu 24 needs the "Autoinstall" type templates, not the classic ones.

Is regular debian fine with the non-autoinstall ones?

Yeah, it's just ubuntu who switched to the new installer.

Well, let's just hope there won't be any other flavor of the preseed templates.

ekohl · 2024-12-03T15:28:00Z

roles/foreman_provisioning/tasks/configure_debian_12_7.yml

+    ptables:
+      - Preseed default
+    state: present
+    password_hash: "SHA256"


Like CentOS

Suggested change

password_hash: "SHA256"

password_hash: "SHA512"

ekohl · 2024-12-03T15:28:15Z

roles/foreman_provisioning/tasks/configure_fedora_40.yml

+    ptables:
+      - Kickstart default
+    state: present
+    password_hash: "SHA256"


Suggested change

password_hash: "SHA256"

password_hash: "SHA512"

ekohl · 2024-12-03T15:35:02Z

roles/foreman_provisioning/tasks/main.yml

  register: foreman_provisioning_hostgroup_centos_mirror
  ignore_errors: True

- name: 'create hostgroup CentOS 7 Mirror'
+- name: 'create hostgroup CentOS 9 Mirror'


Can we replace the hammer logic with FAM here too? theforeman.foreman.hostgroup should be way easier to maintain:

- name: "Ensure CentOS 9 Mirror hostgroup" theforeman.foreman.hostgroup: name: 'CentOS 9 Mirror' operatingsystem: 'CentOS_Stream 9' medium: '{{ foreman_provisioning_centos_medium_name }}' ptable: 'Kickstart default' parent: 'Base'

Not sure how to convert foreman_provisioning_hammer_taxonomy_params easily.

And the same for the Base hostgroup.

ekohl · 2024-12-03T16:17:21Z

roles/foreman_provisioning_infrastructure/tasks/main.yml

In #1888 I had a go at rewriting much of this file to also use FAM. I'd appreciate if you could take a look.

adamruzicka force-pushed the foreman-provisioning branch from d691511 to 2e8254a Compare October 17, 2024 13:37

ekohl reviewed Nov 21, 2024

View reviewed changes

ekohl reviewed Nov 27, 2024

View reviewed changes

adamruzicka added 11 commits December 3, 2024 13:05

Use fully qualified names for libvirt modules

57b6842

Fix puppet environment use in foreman_provisioning

66ad55a

Bump fedora to 40 in foreman_provisioning

d38aefa

Adjust foreman_provisioning to centos stream 9

9dec420

Bump debian to 12.7 in foreman_provisioning

4a3404b

Bump ubuntu to 24.04 in foreman_provisioning

ce85689

Fix root password

62cc747

Configure Debian 12.7 using fam

0cd5277

Configure Fedora 40 using fam

6a33c85

Configure Ubuntu 24.04 using fam

578f05d

Set unattended url using fam

d0c74e9

adamruzicka force-pushed the foreman-provisioning branch from 8418a86 to d0c74e9 Compare December 3, 2024 12:16

evgeni reviewed Dec 3, 2024

View reviewed changes

adamruzicka added 2 commits December 3, 2024 13:34

Make Ubuntu use autoinstall variant of preseed templates

605a7cf

Make centos medium name configurable

954d5c9

ekohl mentioned this pull request Dec 3, 2024

Rely on FAM for much of the foreman_provisioning setup #1888

Open

ekohl reviewed Dec 3, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix foreman_provisioning role #1866

Fix foreman_provisioning role #1866

adamruzicka commented Oct 17, 2024

sjha4 commented Nov 21, 2024

ekohl left a comment

ekohl Nov 21, 2024

ekohl Nov 27, 2024

adamruzicka Nov 29, 2024

ekohl Nov 29, 2024

evgeni Nov 30, 2024

adamruzicka Dec 2, 2024

evgeni Dec 3, 2024 •

edited

Loading

evgeni Dec 3, 2024

adamruzicka Dec 3, 2024

evgeni Dec 3, 2024

evgeni Dec 3, 2024

evgeni Dec 3, 2024

adamruzicka Dec 3, 2024

evgeni Dec 3, 2024

adamruzicka Dec 3, 2024

ekohl Dec 3, 2024

ekohl Dec 3, 2024

ekohl Dec 3, 2024

ekohl Dec 3, 2024

Fix foreman_provisioning role #1866

Are you sure you want to change the base?

Fix foreman_provisioning role #1866

Conversation

adamruzicka commented Oct 17, 2024

sjha4 commented Nov 21, 2024

ekohl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evgeni Dec 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evgeni Dec 3, 2024 •

edited

Loading