Use consistent phrasing #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both of the following should use the same phrasing: webpack/JobWizard/JobWizardPageRerun.js webpack/JobWizard/index.js
|
Do I need to get rid of now unneeded translations as well, or will that happen automatically with the next release? |
That will happen automatically in the next release. |
adamruzicka
approved these changes
May 22, 2024
|
Thank you @quba42 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of the following should use the same phrasing:
webpack/JobWizard/JobWizardPageRerun.js
webpack/JobWizard/index.js
Right now the user experience is as follows:
When Creating a new Job through Monitor → Jobs → Run Job, while in the creation wizard, there is an option to “Use Legacy Form”
After Submitting the Job I land on the Job Result Page and click on Rerun which sends me back to the Job wizard, and now the option that was “Use Legacy Form” says " Use old Form"