Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce a foreman-devel module #9939

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Oct 31, 2023

No description provided.

@evgeni
Copy link
Member Author

evgeni commented Oct 31, 2023

@evgeni
Copy link
Member Author

evgeni commented Oct 31, 2023

I pondered making foreman:el8 have a buildrequires: foreman-devel:el8, but not sure the resulting half-circle is a good idea
(OTOH, nothing uses this buildrequires entry anyway)

@ekohl
Copy link
Member

ekohl commented Oct 31, 2023

(OTOH, nothing uses this buildrequires entry anyway)

Because of this I would do this. On a technical level it doesn't have implications, but avoids duplication.

@ekohl
Copy link
Member

ekohl commented Oct 31, 2023

And now I see you added foreman as a dependency to foreman-devel, so that makes me reconsider. I'd avoid that potential circular dependency.

@evgeni evgeni marked this pull request as ready for review October 31, 2023 15:17
document: modulemd
version: 2
data:
name: foreman-devel
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I picked foreman-devel over foreman-build as it's useful for non-build things too, but the name really does not matter much.

@evgeni evgeni merged commit 553d3f4 into theforeman:rpm/develop Oct 31, 2023
1 check passed
@evgeni evgeni deleted the devel-module branch October 31, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants