Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #36801: Set Redis as the default cache on upgrade #888

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Refs #36801: Set Redis as the default cache on upgrade #888

merged 1 commit into from
Oct 20, 2023

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Oct 5, 2023

No description provided.

@ehelms
Copy link
Member Author

ehelms commented Oct 5, 2023

Puppet change -- theforeman/puppet-foreman#1134

@ehelms ehelms requested a review from ekohl October 16, 2023 23:47
ekohl
ekohl approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good, but tests are red for an unrelated reason. I want to do the big puppetlabs/stdlib 9.x upgrade in our modules, but that will be bumpy.

config/foreman.migrations/20231005004305_redis_default_cache.rb
@@ -0,0 +1,3 @@
if answers['foreman'].is_a?(Hash) && answers.dig('foreman', 'rails_cache_store', 'type') == 'file'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about dig, but didn't suggest it because I wasn't 100% sure if rails_cache_store was always a hash or nil. Now that I think more about it, I think that's all good.

@ehelms
Copy link
Member Author

ehelms commented Oct 17, 2023

I think this is good, but tests are red for an unrelated reason. I want to do the big puppetlabs/stdlib 9.x upgrade in our modules, but that will be bumpy.

Is this theforeman/foreman-installer-modulesync#152 ?

@ekohl
Copy link
Member

ekohl commented Oct 17, 2023

It's related. The stupid thing is that puppetlabs/stdlib 8.x deprecated some functions without replacement and puppetlabs/stdlib 9.0 removed those functions. So the upgrade to 9.x requires to bump the lower bound too. It's really painful. If they only made a compatibility release in 8.x it would have been much smoother.

@ekohl
Copy link
Member

ekohl commented Oct 19, 2023

If you rebase, it should be green because b324bda pinned things.

@ekohl ekohl merged commit 8b7b58d into theforeman:develop Oct 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

@evgeni evgeni evgeni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehelms @ekohl @evgeni