add web service to fastly setup #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
evgeni
commented
Nov 19, 2024
•
evgeni
commented
- allow setting domains manually
- allow configuring healthcheck path
- add web service to fastly setup
ekohl
reviewed
Nov 25, 2024
| @@ -10,8 +10,7 @@ | |||
| fastly_service: | |||
| name: "{{ item.service }}.theforeman.org" | |||
| fastly_api_key: "{{ fastly_api_key }}" | |||
| domains: | |||
| - name: "{{ item.service }}.theforeman.org" | |||
| domains: "{{ item.domains | default([{'name': item.service ~ '.theforeman.org'}]) }}" | |||
There was a problem hiding this comment.
String concat.
As I can't put jinja inside jinja.
There was a problem hiding this comment.
There was a problem hiding this comment.
I guess that and tried to look for that but somehow I couldn't find it.
There was a problem hiding this comment.
documenting things properly is complicated, as you know :)
ekohl
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.