Use generic example password #3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use one argument per line
maximiliankolb
added
tech review done
|
The PR preview for 486b38d is available at theforeman-foreman-documentation-preview-pr-3336.surge.sh The following output files are affected by this PR: |
asteflova
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Ack with just one non-blocking note: The previous example username also implied the need to have administrative privileges (admin). At a quick glance, I don't see the need for these privileges mentioned anywhere else in the document so it makes me wonder whether you should document it (as a prerequisite?) now that you are replacing admin with a generic My_User_Name. (If you think it's not needed, that's perfectly okay with me.)
maximiliankolb
added
style review done
maximiliankolb
added a commit
that referenced
this pull request
Oct 2, 2024
* Use one argument per line (cherry picked from commit 2a942ec)
maximiliankolb
added a commit
that referenced
this pull request
Oct 2, 2024
* Use one argument per line (cherry picked from commit 2a942ec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
removing the example password "redhat" due to branding issues and consistency.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
consistency.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
we have both "last argument | next command" and "last argument \ \n | next command". Any preference?
Checklists
Please cherry-pick my commits into: