Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fillament blade icons fix #150

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Fillament blade icons fix #150

merged 2 commits into from
Nov 7, 2024

Conversation

bobbyiliev
Copy link
Collaborator

As per the discussion here: blade-ui-kit/blade-icons#71 (comment)

We've had a lengthy debug session after we've deployed an update to Laravel + Filament v3 and this eventually turned out to be the culprit. As lao9s described, we could not reproduce it locally but had massive performance issues on a server. We've debugged this using php-fpm slow log.

What's interesting though is that Filament provides their own workaround, which is not documented (https://github.com/filamentphp/filament/blob/e8d44231fcba1a0f4e9625afe7368447d56b2866/packages/panels/src/Http/Middleware/DisableBladeIconComponents.php).

protected $middleware = [
    ...
    \Filament\Http\Middleware\DisableBladeIconComponents::class
];

Simply include this middleware and the blade icons are not loaded anymore.

@bobbyiliev bobbyiliev requested a review from tnylea November 6, 2024 17:05
Comment on lines +1 to +2
*
!.gitignore
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the cached content so that we match the latest Laravel v11

https://github.com/laravel/laravel/blob/11.x/bootstrap/cache/.gitignore

@tnylea
Copy link
Contributor

tnylea commented Nov 7, 2024

Awesome! Thanks for figuring this out and getting it implemented 👏

@tnylea tnylea merged commit 0f93c53 into main Nov 7, 2024
2 checks passed
@bobbyiliev bobbyiliev deleted the fillament-blade-icons-fix branch November 7, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants