Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dark Mode Compatibility for User and Post Widgets #144

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

callum-baillie
Copy link
Contributor

This fixes dark mode support for text elements in the user and post widgets on the admin dashboard. Previously, some text within these widgets was not visible in dark mode due to lack of dark-specific styling. I added dark:text-gray-200 classes to relevant <div> elements to ensure readability in dark mode.

Files Updated

wave/resources/views/widgets/users-widget.blade.php
    Updated `<div>` elements for user count display:
        elements now include dark:text-gray-200 to ensure text visibility in dark mode.

wave/resources/views/widgets/posts-pages-widget.blade.php
    Updated `<div>` elements for post and page count display:
        elements now include dark:text-gray-200 to ensure text visibility in dark mode.

Styling Approach

I couldn't find a specific styling guide indicating what color should be used for dark mode text, I opted for text-gray-200, aligning with similar elements in the dashboard.

Testing

All changes were visually tested in both light and dark modes to confirm that text is now visible and consistent with other elements in the dashboard.

Copy link
Collaborator

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@bobbyiliev bobbyiliev merged commit 0266bd8 into thedevdojo:main Oct 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants