fix: data type mismatch in the subscriptions migration
#138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reordered `subscription` migration to come after the `plans` as it has a FK that refers to the `plans` migrations
bobbyiliev
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
This looks good to me! I'll let @tnylea also check it out before merging!
|
In addition to this, there's a further issue in that the *_create_plans_table.php file has a later timestamp than the *_create_subscrpitions_table.php which causes a failure when migration. The subscriptions table references the plans table in its migration, so the plans table should be created first. |
|
I had the same problem and fixed it myself and wanted to fix it here too but you did it thank you |
|
Looks great to me. Thanks guys! @adamthomason would you mind submitting a PR for that issue with the migration you were experiencing. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Description
This PR addresses an issue with the foreign key constraint between the
subscriptionsandplanstables. The constraint failed due to a data type mismatch between theplan_idin thesubscriptionstable and theidin theplanstable.Fixes Implemented:
subscriptiontable was reordered to run after theplanstable, ensuring that the foreign key reference is established correctly during the migration process.plan_idin thesubscriptionstable to match that of theidin theplanstable, resolving the constraint error.Does this PR introduce a breaking change?
Related Issue
None