[Error handling] Remove category from exceptions #685
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #683, category support has already been removed from graphQL error responses with graphqlite because of graphql-php update to v15 ( see upgrade guide v14 -> v15 ), which means
category
is already missing fromextensions
in responses.The purpose of this PR is to remove the category argument from Exceptions.
Caution
BC Break
The
category
argument has been removed fromGraphQLException
, which means any existing instance of a GraphQLException passing category and/or extensions will trigger an error.BEFORE
AFTER
Note
If you want to keep
category
, you'll have two options :GraphQLException
class and using your ownerrorFormatter
methodextensions
Fixes #683