-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unix OS Driver #150
Open
akutz
wants to merge
3
commits into
thecodeteam:master
Choose a base branch
from
akutz:feature/unix-os-driver
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Unix OS Driver #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package client | ||
|
||
// load the os drivers | ||
import _ "github.com/emccode/libstorage/drivers/os/unix" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a blank import should be only in a main or test package, or have a comment justifying it
akutz
force-pushed
the
feature/unix-os-driver
branch
from
May 23, 2016 18:14
a91441c
to
0ef739d
Compare
Current coverage is 34.28% (diff: 100%)@@ master #150 diff @@
==========================================
Files 36 36
Lines 1909 1919 +10
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 619 658 +39
+ Misses 1223 1195 -28
+ Partials 67 66 -1
|
akutz
force-pushed
the
feature/unix-os-driver
branch
from
June 2, 2016 05:09
0ef739d
to
87b79da
Compare
This patch renames the Linux and Darwin OS drivers to the Unix OS driver. This driver is loaded for both the Linux and Darwin OSs. The Darwin implementation lacks implementations of the Mount & Format functions.
akutz
force-pushed
the
feature/unix-os-driver
branch
from
June 2, 2016 11:13
87b79da
to
470ca6d
Compare
@akutz Is this something you still want to achieve? |
I moved this to the Backlog as it needs to be rebased and updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch renames the Linux and Darwin OS drivers to the Unix OS driver. This driver is loaded for both the Linux and Darwin OSs. The Darwin implementation lacks implementations of the Mount & Format functions.