Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unix OS Driver #150

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

akutz
Copy link
Collaborator

@akutz akutz commented May 23, 2016

This patch renames the Linux and Darwin OS drivers to the Unix OS driver. This driver is loaded for both the Linux and Darwin OSs. The Darwin implementation lacks implementations of the Mount & Format functions.

@akutz akutz added this to the 0.1.1 milestone May 23, 2016
@akutz akutz self-assigned this May 23, 2016
package client

// load the os drivers
import _ "github.com/emccode/libstorage/drivers/os/unix"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a blank import should be only in a main or test package, or have a comment justifying it

@akutz akutz force-pushed the feature/unix-os-driver branch from a91441c to 0ef739d Compare May 23, 2016 18:14
@codecov-io
Copy link

codecov-io commented May 23, 2016

Current coverage is 34.28% (diff: 100%)

Merging #150 into master will increase coverage by 1.86%

@@             master       #150   diff @@
==========================================
  Files            36         36          
  Lines          1909       1919    +10   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            619        658    +39   
+ Misses         1223       1195    -28   
+ Partials         67         66     -1   

Powered by Codecov. Last update c259cfb...0ef739d

@akutz akutz force-pushed the feature/unix-os-driver branch from 0ef739d to 87b79da Compare June 2, 2016 05:09
akutz added 3 commits June 2, 2016 06:13
This patch renames the Linux and Darwin OS drivers to the Unix OS
driver. This driver is loaded for both the Linux and Darwin OSs. The
Darwin implementation lacks implementations of the Mount & Format
functions.
@akutz akutz force-pushed the feature/unix-os-driver branch from 87b79da to 470ca6d Compare June 2, 2016 11:13
@codenrhoden
Copy link
Contributor

@akutz Is this something you still want to achieve?

@akutz
Copy link
Collaborator Author

akutz commented Mar 28, 2017

I moved this to the Backlog as it needs to be rebased and updated.

@codenrhoden codenrhoden removed this from the 0.1.1 milestone Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants