feat(insim_core): Game version parsing #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theangryangel
force-pushed
the
feat-version-features
branch
2 times, most recently
from
f42b7be to
8f6c82b
Compare
|
Good idea! Are you going to use this to parse the version string in the IS_VER packet? |
I think so. I want to sort out the GameParseError struct and then I was going to call it a day. The only lingering worry is that I've guessed wrong or Scawen changes convention suddenly |
theangryangel
force-pushed
the
feat-version-features
branch
from
8f6c82b to
c6b2701
Compare
theangryangel
force-pushed
the
feat-version-features
branch
from
c6b2701 to
5e19bf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse a version string and break it into it's component parts.
Implements ordering and sorting.
Based 100% on the informal rules that I think Scawen follows.