Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance PanAndZoom with touch support for pinch zoom and single-finger pan #71

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

sago35
Copy link
Contributor

@sago35 sago35 commented Dec 26, 2023

#20

This PR adds touch support.
It's a minimal implementation, but it allows for comfortable use of KiCanvas from platforms like Android.

See https://twitter.com/i/status/1739613481052307890

@sago35
Copy link
Contributor Author

sago35 commented Dec 26, 2023

I have confirmed that touch support works in the following environments:

  • Android
  • iPhone
  • Windows 11 + TouchScreen

@theacodes
Copy link
Owner

Looks like lint is failing, do you mind giving that a look?

@sago35
Copy link
Contributor Author

sago35 commented Dec 28, 2023

I have fixed the issue. However, it seems that the following warning still exists. I have not corrected this warning, but I can do so if needed.

$ npm run lint:prettier

> [email protected] lint:prettier
> prettier . --check

Checking formatting...
[warn] src/kicanvas/elements/kc-board/properties-panel.ts
[warn] src/kicanvas/elements/kc-schematic/properties-panel.ts
[warn] Code style issues found in 2 files. Run Prettier to fix.

@sago35
Copy link
Contributor Author

sago35 commented Jan 8, 2024

@theacodes
Can you run the CI first?

@theacodes
Copy link
Owner

Looks good. Any thing else before I merge? :)

@sago35
Copy link
Contributor Author

sago35 commented Jan 8, 2024

@theacodes
It's fine to merge as it is. Thank you for checking.

@theacodes theacodes merged commit 5c38d14 into theacodes:main Jan 11, 2024
2 checks passed
@sago35 sago35 deleted the touch branch January 11, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants