Skip to content

Commit

Permalink
Drop .actionHandle
Browse files Browse the repository at this point in the history
  • Loading branch information
the-djmaze committed Oct 2, 2023
1 parent 57b804f commit e1649d0
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 11 deletions.
6 changes: 2 additions & 4 deletions dev/Common/Selector.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,13 @@ export class Selector {
* @param {koProperty} koFocusedItem
* @param {string} sItemSelector
* @param {string} sItemCheckedSelector
* @param {string} sItemFocusedSelector
*/
constructor(
koList,
koSelectedItem,
koFocusedItem,
sItemSelector,
sItemCheckedSelector,
sItemFocusedSelector
sItemCheckedSelector
) {
koFocusedItem = (koFocusedItem || ko.observable(null)).extend({ toggleSubscribeProperty: [this, 'focused'] });
koSelectedItem = (koSelectedItem || ko.observable(null)).extend({ toggleSubscribeProperty: [null, 'selected'] });
Expand All @@ -46,7 +44,7 @@ export class Selector {

this.sItemSelector = sItemSelector;
this.sItemCheckedSelector = sItemCheckedSelector;
this.sItemFocusedSelector = sItemFocusedSelector;
this.sItemFocusedSelector = sItemSelector + '.focused';

this.sLastUid = '';
this.oCallbacks = {};
Expand Down
5 changes: 2 additions & 3 deletions dev/View/Popup/Contacts.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,8 @@ export class ContactsPopupView extends AbstractViewPopup {
ContactUserStore,
this.selectorContact,
null,
'.e-contact-item .actionHandle',
'.e-contact-item .checkboxItem',
'.e-contact-item.focused'
'.e-contact-item',
'.e-contact-item .checkboxItem'
);

this.selector.on('ItemSelect', contact => this.populateViewContact(contact));
Expand Down
5 changes: 2 additions & 3 deletions dev/View/User/MailBox/MessageList.js
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,7 @@ export class MailMessageList extends AbstractViewRight {
MessagelistUserStore.selectedMessage,
MessagelistUserStore.focusedMessage,
'.messageListItem',
'.messageListItem .messageCheckbox',
'.messageListItem.focused'
'.messageListItem .messageCheckbox'
);

this.selector.on('ItemSelect', message => {
Expand Down Expand Up @@ -614,7 +613,7 @@ export class MailMessageList extends AbstractViewRight {
eqs(event, '.checkboxCheckAll') && this.checkAll(!this.checkAll());
},
dblclick: event => {
let el = eqs(event, '.actionHandle');
let el = eqs(event, '.messageListItem');
el && this.gotoThread(ko.dataFor(el));
}
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
<div class="e-contact-foreach g-ui-user-select-none" data-bind="foreach: contacts, visible: contacts().length">
<div class="e-contact-item g-ui-user-select-none" data-bind="css: lineAsCss()">
<div class="checkboxItem fontastic" data-bind="text: checked() ? '☑' : '☐'"></div>
<div class="nameParent actionHandle" data-bind="text: display"></div>
<div class="nameParent" data-bind="text: display"></div>
</div>
</div>
</div>
Expand Down

0 comments on commit e1649d0

Please sign in to comment.