Apply suggestions from code review

Co-authored-by: Saswata Mukherjee <[email protected]> Signed-off-by: Nicolas Takashi <[email protected]>
thanos-io · Dec 20, 2024 · 63ce67b · 63ce67b
1 parent 12dbf04
commit 63ce67b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/cmd/thanos/receive.go b/cmd/thanos/receive.go
@@ -1056,8 +1056,8 @@ func (rc *receiveConfig) registerFlag(cmd extkingpin.FlagClause) {
 	cmd.Flag("receive.limits-config-reload-timer", "Minimum amount of time to pass for the limit configuration to be reloaded. Helps to avoid excessive reloads.").
 		Default("1s").Hidden().DurationVar(&rc.limitsConfigReloadTimer)
 
-	cmd.Flag("receive.otlp-disable-target-info", "Disable target information in OTLP metrics.").Default("false").BoolVar(&rc.otlpDisableTargetInfo)
-	cmd.Flag("receive.otlp-resource-attributes", "Resource attributes to include in OTLP metrics.").Default("").StringsVar(&rc.otlpResourceAttributes)
+	cmd.Flag("receive.otlp-disable-target-info", "Disable target information OTLP metrics ingested by Receive.").Default("false").BoolVar(&rc.otlpDisableTargetInfo)
+	cmd.Flag("receive.otlp-resource-attributes", "(Repeatable) Resource attributes to include in OTLP metrics ingested by Receive.").Default("").StringsVar(&rc.otlpResourceAttributes)
 
 	rc.featureList = cmd.Flag("enable-feature", "Comma separated experimental feature names to enable. The current list of features is "+metricNamesFilter+".").Default("").Strings()
 }

diff --git a/pkg/receive/handler.go b/pkg/receive/handler.go
@@ -278,7 +278,7 @@ func NewHandler(logger log.Logger, o *Options) *Handler {
 	)
 
 	h.router.Post(
-		"/v1/metrics",
+		"/api/v1/otlp",
 		instrf(
 			"otlp",
 			readyf(
-Original file line number
+Diff line change
@@ Expand Up / @@ -278,7 +278,7 @@ func NewHandler(logger log.Logger, o *Options) *Handler { @@
     	)
     	h.router.Post(
-    		"/v1/metrics",
+    		"/api/v1/otlp",
     		instrf(
     			"otlp",
     			readyf(
@@ Expand Down @@